From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56417) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZfVTK-0001TH-Gm for qemu-devel@nongnu.org; Fri, 25 Sep 2015 12:04:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZfVT2-0001Zy-Dq for qemu-devel@nongnu.org; Fri, 25 Sep 2015 12:03:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51065) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZfVT2-0001Zj-5O for qemu-devel@nongnu.org; Fri, 25 Sep 2015 12:03:24 -0400 References: <1443189844-20341-1-git-send-email-marcandre.lureau@redhat.com> <1443189844-20341-6-git-send-email-marcandre.lureau@redhat.com> From: Eric Blake Message-ID: <56056542.7020508@redhat.com> Date: Fri, 25 Sep 2015 09:16:18 -0600 MIME-Version: 1.0 In-Reply-To: <1443189844-20341-6-git-send-email-marcandre.lureau@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Q6qBH252KJFjRtMSxdtM8KKhtNCNERrHG" Subject: Re: [Qemu-devel] [PATCH 05/36] qapi: move examples to json schema List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: marcandre.lureau@redhat.com, qemu-devel@nongnu.org Cc: armbru@redhat.com, mdroth@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Q6qBH252KJFjRtMSxdtM8KKhtNCNERrHG Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/25/2015 08:03 AM, marcandre.lureau@redhat.com wrote: > From: Marc-Andr=C3=A9 Lureau >=20 > Clean-up qmp-commands.hx from examples. >=20 > Signed-off-by: Marc-Andr=C3=A9 Lureau > --- > qapi-schema.json | 1128 +++++++++++++++- > qapi/block-core.json | 365 +++++ > qapi/block.json | 32 + > qapi/common.json | 32 + > qapi/rocker.json | 43 + > qapi/trace.json | 12 + > qmp-commands.hx | 3617 +-----------------------------------------= -------- > 7 files changed, 1625 insertions(+), 3604 deletions(-) Mammoth patch. I don't know if it would make sense to break it into smaller pieces (say 10 or so related commands per patch) - more emails, but each email is more reviewable, and the review can be divided among the various maintainers that implement those various commands. Or even if there were an easy way to automate the diff to prove that every example was exactly moved, regardless of whether the example is correct. I'm not necessarily opposed to keeping it as one big patch, just that it is a big commitment to review. And I do like where we end up, it's just that I'm worried about making sure we don't regress along the way (particularly if other QMP command examples are introduced along the way before this gets merged - we already had a recent example of a regression in -help output for PCI devices due to text being added to one file in parallel with another patch that moved the text between files= ). Also, I'd love to see docs/qapi-code-gen.txt updated to list Example: as a proper part of a sample qapi listing. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --Q6qBH252KJFjRtMSxdtM8KKhtNCNERrHG Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWBWVCAAoJEKeha0olJ0NqZ6gH/RcNyNHa7/v86bQOes4FZw/H zuyq1sB70T8Js2kd5dzX8IlBnJRlbhkdWrJ6lIr+P+bJDEmCs2ll8sItFlCLsDE9 cbDInIbXtwjU7/2P+th8uC+RyzIeU2NwKUTHmt7SF5FStkoTog2uq0DuUCy9BaPQ wG43qvt4LZd0ix64b7mB8OSYq0pXQBf8iDkZKXjpzpQaNnfT2aAHqukDzWzk/x6M NXPE4KJu0R+u5q0+RQg0b+5PbwS9zbsCCcAb6pQjWp2rt6UpxqqnLA7/ZoIt7fWr I2fCqXtDLPFHEIAd8jHyo9epAcoDN9BbMGa2i/EO/u4tU/ysO5b8LoKpfq1bf0I= =MwKd -----END PGP SIGNATURE----- --Q6qBH252KJFjRtMSxdtM8KKhtNCNERrHG--