From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47705) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZfVAz-0004Mz-Fg for qemu-devel@nongnu.org; Fri, 25 Sep 2015 11:44:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZfVAw-0008LI-9O for qemu-devel@nongnu.org; Fri, 25 Sep 2015 11:44:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56805) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZfVAw-0008L7-52 for qemu-devel@nongnu.org; Fri, 25 Sep 2015 11:44:42 -0400 References: <1443189844-20341-1-git-send-email-marcandre.lureau@redhat.com> <1443189844-20341-11-git-send-email-marcandre.lureau@redhat.com> From: Eric Blake Message-ID: <56056BE8.10606@redhat.com> Date: Fri, 25 Sep 2015 09:44:40 -0600 MIME-Version: 1.0 In-Reply-To: <1443189844-20341-11-git-send-email-marcandre.lureau@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="PPGnvhC3OP2aMsk0pPjGs0E1bbUWpBBjL" Subject: Re: [Qemu-devel] [PATCH 10/36] texi2pod: learn quotation, deftp and deftypefn List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: marcandre.lureau@redhat.com, qemu-devel@nongnu.org Cc: armbru@redhat.com, mdroth@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --PPGnvhC3OP2aMsk0pPjGs0E1bbUWpBBjL Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/25/2015 08:03 AM, marcandre.lureau@redhat.com wrote: > From: Marc-Andr=C3=A9 Lureau >=20 > Learn a few more markups used for API documentation. >=20 > Signed-off-by: Marc-Andr=C3=A9 Lureau > --- > scripts/texi2pod.pl | 44 +++++++++++++++++++++++++++++++++++++++++++- > 1 file changed, 43 insertions(+), 1 deletion(-) This file was originally from gcc (we forked it from a point before gcc upstream made theirs GPLv3). Are your additions written from scratch, or are they copied from somewhere else like gcc? Might be nice to be explicit in your commit message. I'm not the best perl reviewer, but the obvious test is whether the resulting output file looks clean; offhand that seems to be the case, but I'm not confident enough to leave R-b on this pass of reviews. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --PPGnvhC3OP2aMsk0pPjGs0E1bbUWpBBjL Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWBWvoAAoJEKeha0olJ0NqFz0H/3AvkM0qQysAg45wceUY9LuW NWSEBY88/cYmXUTmsKM0CVEFm7SmaQM2TCIqPOd3CMtkgU7K8KCKxrFb00MU4PgB FVccVr0GsLo0iqJsfc1gK4bPirwluaJuvDlFg+LhFg1wSioOpwdo6y1wVd5L2nhm YiqRk92LZCXeJH3j4ywSWc+bJd6zLbnDYRZqrEb5bXBqp94QedHumtx3FB3IdkLl DZVkq57tcoxofAfcWxEpvqT6VMxnj1UAMM4yENJ7bT9q9DUfShETdySUZ2VRpYkB ksKo/CqHVDq3nYNq40OVeCcM6zBV3EnT1IT6pmwbqCKQM1IGxS4XanPFa6mWp0w= =kJOe -----END PGP SIGNATURE----- --PPGnvhC3OP2aMsk0pPjGs0E1bbUWpBBjL--