From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49494) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZfVFm-00006O-2J for qemu-devel@nongnu.org; Fri, 25 Sep 2015 11:49:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZfVFh-0001qO-5Z for qemu-devel@nongnu.org; Fri, 25 Sep 2015 11:49:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53923) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZfVFg-0001qK-UM for qemu-devel@nongnu.org; Fri, 25 Sep 2015 11:49:37 -0400 References: <1443189844-20341-1-git-send-email-marcandre.lureau@redhat.com> <1443189844-20341-12-git-send-email-marcandre.lureau@redhat.com> From: Eric Blake Message-ID: <56056D0E.8040409@redhat.com> Date: Fri, 25 Sep 2015 09:49:34 -0600 MIME-Version: 1.0 In-Reply-To: <1443189844-20341-12-git-send-email-marcandre.lureau@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="PwbofcN3fRFjPkVRN48dEhUsl8e7Tf3qK" Subject: Re: [Qemu-devel] [PATCH 11/36] build-sys: generate QAPI doc based on json List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: marcandre.lureau@redhat.com, qemu-devel@nongnu.org Cc: armbru@redhat.com, mdroth@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --PwbofcN3fRFjPkVRN48dEhUsl8e7Tf3qK Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/25/2015 08:03 AM, marcandre.lureau@redhat.com wrote: > From: Marc-Andr=C3=A9 Lureau >=20 > Learn to generate info/html/pdf/man documentation for QEMU and agent QM= P > APIs. >=20 > This allows to provide missing agent documentation, and should help "allows to" is not idiomatic English (it is missing a subject of who is being allowed). Better would be either: This allows us to provide missing agent documentation, This provides missing agent documentation, although I'd lean to the shorter form. > getting rid of the duplicate documentation in qmp-commands.hx. >=20 > Signed-off-by: Marc-Andr=C3=A9 Lureau > --- > Makefile | 36 ++++++++++++++++++++++++++++++------ > 1 file changed, 30 insertions(+), 6 deletions(-) > @@ -363,7 +364,7 @@ distclean: clean > rm -f qemu-doc.vr > rm -f config.log > rm -f linux-headers/asm > - rm -f qemu-tech.info qemu-tech.aux qemu-tech.cp qemu-tech.dvi qemu-te= ch.fn qemu-tech.info qemu-tech.ky qemu-tech.log qemu-tech.pdf qemu-tech.p= g qemu-tech.toc qemu-tech.tp qemu-tech.vr > + rm -f qemu-tech.info qemu-tech.aux qemu-tech.cp qemu-tech.dvi qemu-te= ch.fn qemu-tech.info qemu-tech..ky qemu-tech.log qemu-tech.pdf qemu-tech.= pg qemu-tech.toc qemu-tech.tp qemu-tech.vr qemu-qapi.info qemu-qapi.aux q= emu-qapi.cp qemu-qapi.dvi qemu-qapi.fn qemu-qapi.info qemu-qapi..ky qemu-= qapi.log qemu-qapi.pdf qemu-qapi.pg qemu-qapi.toc qemu-qapi.tp qemu-qapi.= vr qemu-ga-qapi.info qemu-ga-qapi.aux qemu-ga-qapi.cp qemu-ga-qapi.dvi qe= mu-ga-qapi.fn qemu-ga-qapi.info qemu-ga-qapi..ky qemu-ga-qapi.log qemu-ga= -qapi.pdf qemu-ga-qapi.pg qemu-ga-qapi.toc qemu-ga-qapi.tp qemu-ga-qapi.v= r This line is now way long; can we use \ continuation to split it into something easier to manage? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --PwbofcN3fRFjPkVRN48dEhUsl8e7Tf3qK Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWBW0PAAoJEKeha0olJ0Nqy1kH/0dlqFY0cA5kD1phrT66/EAV WCwVTgLvsCUjXX/GVfsT6kObLKeQ/yWtnnbVSzI5ZHj84mHcV/hUV5+s7jBNkVAb JedoAv01C/3KoAfW6CJnUojNiRFYT57M/f7Hl3yeVaTGuE4dnsYVGtHNwkaUF2XF 9Hk6TsFvwHBFH2Fn+G+C1RGD17UtITaZ7SaCUp1u8mQD4h4Cbq0P/YpmGG3lK5qv mGjzf/VothrsGHnlo17B/n0ubesAD64JSBjZW8PXBIZgsVvxhyWmP1p2gcNRVhoc AQglwrqG3Jb4mv+AL3a7YkaeePvF5PquZi3gEkZwrVG3FFmuVmXm5dTGnXVHimw= =gL9O -----END PGP SIGNATURE----- --PwbofcN3fRFjPkVRN48dEhUsl8e7Tf3qK--