From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52633) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZfVMU-0002mE-BN for qemu-devel@nongnu.org; Fri, 25 Sep 2015 11:56:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZfVMP-0006P3-Bv for qemu-devel@nongnu.org; Fri, 25 Sep 2015 11:56:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48968) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZfVMP-0006Os-5q for qemu-devel@nongnu.org; Fri, 25 Sep 2015 11:56:33 -0400 References: <1443189844-20341-1-git-send-email-marcandre.lureau@redhat.com> <1443189844-20341-16-git-send-email-marcandre.lureau@redhat.com> From: Eric Blake Message-ID: <56056EAF.1050007@redhat.com> Date: Fri, 25 Sep 2015 09:56:31 -0600 MIME-Version: 1.0 In-Reply-To: <1443189844-20341-16-git-send-email-marcandre.lureau@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="IMsMpjOxHoLhGiT1XkfCJkG94fjkFCaqD" Subject: Re: [Qemu-devel] [PATCH 15/36] monitor: register gen:false commands manually List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: marcandre.lureau@redhat.com, qemu-devel@nongnu.org Cc: armbru@redhat.com, mdroth@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --IMsMpjOxHoLhGiT1XkfCJkG94fjkFCaqD Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/25/2015 08:03 AM, marcandre.lureau@redhat.com wrote: > From: Marc-Andr=C3=A9 Lureau >=20 > Since some commands are using 'gen': false, they are not registered > automatically by the generator. Register manually instead. >=20 > Signed-off-by: Marc-Andr=C3=A9 Lureau > --- > monitor.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) >=20 > diff --git a/monitor.c b/monitor.c > index 410c3a5..a979924 100644 > --- a/monitor.c > +++ b/monitor.c > @@ -945,6 +945,16 @@ static void qmp_query_qmp_schema(QDict *qdict, QOb= ject **ret_data, > *ret_data =3D qobject_from_json(qmp_schema_json); > } > =20 > +static void qmp_init_marshal(void) > +{ > + qmp_register_command("query-qmp-schema", qmp_query_qmp_schema, > + QCO_NO_OPTIONS); > + qmp_register_command("device_add", qmp_device_add, > + QCO_NO_OPTIONS); > +} device_add wasn't even mentioned in a *.json file before your series. /me goes and looks Oh, you sneakily added it in "qapi: move examples to json schema". Please separate that into its own patch, as it is more than just moving examples. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --IMsMpjOxHoLhGiT1XkfCJkG94fjkFCaqD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWBW6vAAoJEKeha0olJ0NqFjAH/2PSBz8a46IBv/kzPSlAKJ9L oHIB4l1HFcwpZOVp60tUYCJvzeBS+cc+KHGIivpjt6b/3YUtWHm9mOykeKONBuy1 aXJL8k1K9m3WJMcA0xf1KL/J4eWPTGUjgV8v83S5WjVMvoiZwgnx9mU/e8LjjC9c vTMWM8KQBmzKqRilYdcNKhR4nf7nYVIQBoiCiEyd57+g+ZX7n1ZImb8ZAb5AAiR9 hNKqAq2/QewEO48T1OIXxRlyejhnLIsIzajbLUhF2nj73cbVFxJGlwac+lt+bs8J 1xaaFnyfeo9qMc0dGmN6xx2flSuTXBSbfNesqiOJBlWOzM27Ju0W11qZJw4+aug= =xxTC -----END PGP SIGNATURE----- --IMsMpjOxHoLhGiT1XkfCJkG94fjkFCaqD--