From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44708) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZfYT1-0005RU-MZ for qemu-devel@nongnu.org; Fri, 25 Sep 2015 15:15:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZfYSx-0004bA-Ml for qemu-devel@nongnu.org; Fri, 25 Sep 2015 15:15:35 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49412) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZfYSw-0004Zz-Jk for qemu-devel@nongnu.org; Fri, 25 Sep 2015 15:15:31 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 0F176C0B9192 for ; Fri, 25 Sep 2015 19:15:29 +0000 (UTC) References: <1443189647-11417-1-git-send-email-armbru@redhat.com> <1443189647-11417-4-git-send-email-armbru@redhat.com> From: Eric Blake Message-ID: <56059D50.4070401@redhat.com> Date: Fri, 25 Sep 2015 13:15:28 -0600 MIME-Version: 1.0 In-Reply-To: <1443189647-11417-4-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="XXpHQ8gEKOA1wL1w89GPIgrVveDijis08" Subject: Re: [Qemu-devel] [RFC 3/6] monitor: Split MonitorQAPIEventConf off MonitorQAPIEventState List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: amit.shah@redhat.com, marcandre.lureau@redhat.com, lersek@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --XXpHQ8gEKOA1wL1w89GPIgrVveDijis08 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/25/2015 08:00 AM, Markus Armbruster wrote: > In preparation of turning monitor_qapi_event_state[] into a hash table > for finer grained throttling. >=20 > Signed-off-by: Markus Armbruster > --- > monitor.c | 79 ++++++++++++++++++++++++++++++-------------------------= -------- > 1 file changed, 38 insertions(+), 41 deletions(-) >=20 > -/* > - * @event: the event ID to be limited > - * @rate: the rate limit in milliseconds > - * > - * Sets a rate limit on a particular event, so no > - * more than 1 event will be emitted within @rate > - * milliseconds > - */ > -static void > -monitor_qapi_event_throttle(QAPIEvent event, int64_t rate) > -{ At one point, I think we were considering having the rate be user-tunable through a qom property, in which case this function is still nicer than a monitor_qapi_event_conf[] fixed-rate table. But since I don't think we ever used it, I'm fine with dropping the complexity and living with a constant rate. Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --XXpHQ8gEKOA1wL1w89GPIgrVveDijis08 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWBZ1QAAoJEKeha0olJ0Nq2rkH/2Q1BmcPWfF30LepKYXHfZY8 1MmqqPQxyYXazVtXYlJPJq8KmP8ppQF43XIfQBgFo8Zf0pxcAlpDU3LKVZySKsuH gI/1l9+8bjxW4PNfVi1HGOAoy1oSa/ucaRFEXS/bPgP47mqULpR/JT1FNfEU9gQ8 JcpE6vt639+doOyiXKVNl79ElDq18qcPxNtgqqmIVGEtrbuYGqtvX8vEEX7z5h4m ZelIF89HGgwvZ6MDtVI6Pp8piOlMngIZmt2Rgu8WOyJ1BNchznS07r1NoR8ORSSL a1GWISdvgMLDFg0SITwOhO98L+6FK7/7N4uATu4we+S8ZfxfsK1Pbem/8vqbLBQ= =jSwj -----END PGP SIGNATURE----- --XXpHQ8gEKOA1wL1w89GPIgrVveDijis08--