From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48154) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZfYbP-0003zz-IJ for qemu-devel@nongnu.org; Fri, 25 Sep 2015 15:24:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZfYbO-0002bU-KY for qemu-devel@nongnu.org; Fri, 25 Sep 2015 15:24:15 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41139) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZfYbO-0002bG-G2 for qemu-devel@nongnu.org; Fri, 25 Sep 2015 15:24:14 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 2B084461E7 for ; Fri, 25 Sep 2015 19:24:14 +0000 (UTC) References: <1443189647-11417-1-git-send-email-armbru@redhat.com> <1443189647-11417-6-git-send-email-armbru@redhat.com> From: Eric Blake Message-ID: <56059F5C.4000400@redhat.com> Date: Fri, 25 Sep 2015 13:24:12 -0600 MIME-Version: 1.0 In-Reply-To: <1443189647-11417-6-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="CuRnCB3jQOEerAvG1I2W12mTrlrUoK31N" Subject: Re: [Qemu-devel] [RFC 5/6] monitor: Throttle event VSERPORT_CHANGE separately by "id" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: amit.shah@redhat.com, marcandre.lureau@redhat.com, lersek@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --CuRnCB3jQOEerAvG1I2W12mTrlrUoK31N Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/25/2015 08:00 AM, Markus Armbruster wrote: > VSERPORT_CHANGE is emitted when the guest opens or closes a > virtio-serial port. The event's member "id" identifies the port. >=20 > When several events arrive quickly, throttling drops all but the last > of them. Because of that, a QMP client must assume that *any* port > may have changed state when it receives a VSERPORT_CHANGE event and > throttling may have happened. >=20 > Make the event more useful by throttling it for each port separately. >=20 > Signed-off-by: Markus Armbruster > --- > monitor.c | 18 ++++++++++++++++-- > 1 file changed, 16 insertions(+), 2 deletions(-) >=20 All future differentiation would be added as additional special cases within the hash functions, but I like this approach for keeping the rest of the algorithm independent from what the hashing considers as equivalen= t. Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --CuRnCB3jQOEerAvG1I2W12mTrlrUoK31N Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWBZ9dAAoJEKeha0olJ0Nqrr4H/iGy1VdZBRILKpRwwaxF0fet lILFfj0spVv4gcyJJ0IoXDlSyPgaoCu6KUlYzp7UygsYlT4O5ygsxjIs74TKjII9 9M/9EhyhhSO3o4Si2g6WSDqajDOZAJh0l3hYIkeHy6EjTgOBQDUiJPcuPmycWsLi H0yF+odPC5vKlbSdbzaHN21VP4zXzA7E5anM7ORa0pyQF0EAMH5u2ORbfze2vher a/TI5iUaHCA5T9DMm/KN1nPXvcAyifEyk32bXQ/QVrDqzNwF1o3VfwMWeaY5z2pV ORAi/O8ghtt65H4GbDmoZMHt5IFKiw4W19VXSu1mvAju8SACm8iagaEjHNrsLg0= =Ka6q -----END PGP SIGNATURE----- --CuRnCB3jQOEerAvG1I2W12mTrlrUoK31N--