From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52140) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZfYkG-0001ES-I5 for qemu-devel@nongnu.org; Fri, 25 Sep 2015 15:33:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZfYkD-0007wb-CO for qemu-devel@nongnu.org; Fri, 25 Sep 2015 15:33:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59730) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZfYkD-0007w4-5C for qemu-devel@nongnu.org; Fri, 25 Sep 2015 15:33:21 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id BBA69A37E8 for ; Fri, 25 Sep 2015 19:33:20 +0000 (UTC) References: <1443189647-11417-1-git-send-email-armbru@redhat.com> <1443189647-11417-7-git-send-email-armbru@redhat.com> From: Eric Blake Message-ID: <5605A17F.1090001@redhat.com> Date: Fri, 25 Sep 2015 13:33:19 -0600 MIME-Version: 1.0 In-Reply-To: <1443189647-11417-7-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="e40A4rKdfDNhxApcHOfInH79478DvT2MU" Subject: Re: [Qemu-devel] [RFC 6/6] docs: Document QMP event rate limiting List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: amit.shah@redhat.com, marcandre.lureau@redhat.com, lersek@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --e40A4rKdfDNhxApcHOfInH79478DvT2MU Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/25/2015 08:00 AM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > docs/qmp/qmp-events.txt | 12 ++++++++++++ > docs/qmp/qmp-spec.txt | 5 +++++ > 2 files changed, 17 insertions(+) Obvious rebase implied if your other patch to s,docs/qmp/,docs/, goes through. >=20 > diff --git a/docs/qmp/qmp-events.txt b/docs/qmp/qmp-events.txt > index d92cc48..d2f1ce4 100644 > --- a/docs/qmp/qmp-events.txt > +++ b/docs/qmp/qmp-events.txt > @@ -28,6 +28,8 @@ Example: > "data": { "actual": 944766976 }, > "timestamp": { "seconds": 1267020223, "microseconds": 435656 } } > =20 > +Note: this event is rate-limited. Marc-Andre's series moves all the documentation into the .json files; maybe we could make it easier by just listing rate-limiting in the .json files for now, rather than having to churn through which file(s) document things. Do we want to document that VSERPORT_CHANGE rate limiting is per-"id"? > +++ b/docs/qmp/qmp-spec.txt > @@ -175,6 +175,11 @@ The format of asynchronous events is: > For a listing of supported asynchronous events, please, refer to the > qmp-events.txt file. > =20 > +Some events are rate-limited to at most one per second. If more > +events arrive within one second, all but the last one are dropped, and= > +the last one is delayed. Rate-limiting applies to each kind of event > +separately. Do we also want to document that limits might be further tuned according to other elements of the event, with VSERPORT_CHANGE "id" as the example?= --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --e40A4rKdfDNhxApcHOfInH79478DvT2MU Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWBaF/AAoJEKeha0olJ0Nqz2wH/A2uCQSVjbdTxFh7Ggg5lKn9 VX4alkyzn5iVkzrxTojxYqMY4QCGTrRHM2srQYzapp5ndM1LnsoZjPyXS2eVOjDK /iDmU97AYerRTg74TWYVazeH0BUVkwgPalwsKwiLF5HUUR3KH+Iu9kRa87nzSGfR x7ux5H9YiNiG6j1QAf5j0BQFLnSbyi1RLhuYVypYzyFI3kzitiPovOgDMZcMdlgl R4wCt4qvSSiChN35/EfEx82N9tea+S3sJp4mSYV+xCmdqWCjEVpvP8KUvw6syewp JXBALYzhYFTHmRwLZYqIbpbq5cZAfNAIQ3+VH/G5GNcIg1gx1E/OxIENDAQ0O1M= =PIPS -----END PGP SIGNATURE----- --e40A4rKdfDNhxApcHOfInH79478DvT2MU--