From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49450)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1ZfsEk-0007hO-Su
	for qemu-devel@nongnu.org; Sat, 26 Sep 2015 12:22:11 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1ZfsEh-0006HJ-QQ
	for qemu-devel@nongnu.org; Sat, 26 Sep 2015 12:22:10 -0400
References: <1443170278-9318-1-git-send-email-shraddha.6596@gmail.com>
	<1443170278-9318-3-git-send-email-shraddha.6596@gmail.com>
From: Eric Blake <eblake@redhat.com>
Message-ID: <5606C4A1.60509@redhat.com>
Date: Sat, 26 Sep 2015 10:15:29 -0600
MIME-Version: 1.0
In-Reply-To: <1443170278-9318-3-git-send-email-shraddha.6596@gmail.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature";
	boundary="EuoraqkL6ibUvVDmOciV2opmg4guD8Orm"
Subject: Re: [Qemu-devel] [PATCH 3/3] Target-ppc: Remove unnecessary variable
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Shraddha Barke <shraddha.6596@gmail.com>, kvm@vger.kernel.org, qemu-trivial@nongnu.org, Michael Tokarev <mjt@tls.msk.ru>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel <qemu-devel@nongnu.org>

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--EuoraqkL6ibUvVDmOciV2opmg4guD8Orm
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On 09/25/2015 02:37 AM, Shraddha Barke wrote:
> Compress lines and remove the variable.
>=20

> +++ b/target-ppc/kvm.c
> @@ -1782,8 +1782,7 @@ uint32_t kvmppc_get_tbfreq(void)
> =20
>      ns++;
> =20
> -    retval =3D atoi(ns);
> -    return retval;
> +    return atoi(ns);

atoi() is lousy; it cannot properly detect user input errors.  This
should probably be converted to use the appropriate qemu_strtol variant
instead.

--=20
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


--EuoraqkL6ibUvVDmOciV2opmg4guD8Orm
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
Comment: Public key at http://people.redhat.com/eblake/eblake.gpg
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBCAAGBQJWBsSmAAoJEKeha0olJ0NqhKAH/2yu7OdT83+/AGDc95MwT2Lp
hif8cllpZR0ILRezGDwQp++/B3XnSwXxvGlMLXvNh9uXVRKiFkbGEdOViq1vva2j
RW5rrvz0syRo+O1fNZ32pad4zuSdASP2HNq4e/xm8Z4aYNLvNlmyvnlRfdPaVIqL
wM+VCOuX+SHa1jNG9QdSxCJUNfwWlRqNYbhOWBTj6bvaV0+dsb+VQygmtabzfrIT
UpnTNnZJCWI61O+bekSWoSDpCRGkpjc/putLiYAdCFCF3h+EmabkNOpslabB9dOl
y6f+bmwBIWV/iIDLNDGDyp6g2IMgrGDJG3kTdnK3vN30a0sqlwvN+cSC6afI18Q=
=iT3e
-----END PGP SIGNATURE-----

--EuoraqkL6ibUvVDmOciV2opmg4guD8Orm--