From: Jason Wang <jasowang@redhat.com>
To: Eric Blake <eblake@redhat.com>,
Yang Hongyang <yanghy@cn.fujitsu.com>,
qemu-devel@nongnu.org
Cc: armbru@redhat.com
Subject: Re: [Qemu-devel] [PATCH v1] netfilter: various comment fixes
Date: Mon, 28 Sep 2015 14:13:29 +0800 [thread overview]
Message-ID: <5608DA89.3080905@redhat.com> (raw)
In-Reply-To: <56055A7F.1090700@redhat.com>
On 09/25/2015 10:30 PM, Eric Blake wrote:
> On 09/25/2015 02:08 AM, Yang Hongyang wrote:
>> This patchset addressed Markus comment on netfilter patch
>> series, most of them are comment fixes.
>>
>> It is based on jason's net tree:
>> https://github.com/jasowang/qemu/tree/net
> If that tree is not yet merged mainline, wouldn't it be better to squash
> these fixes directly into the offending patches, instead of using it as
> a followup patch?
Yes, and maybe a new version.
>
>> /*
>> - * we return size when buffer a packet, the sender will take it as
>> - * a already sent packet, so sent_cb should not be called later
>> - * FIXME: even if guest can't receive packet for some reasons. Filter
>> + * We return size when buffer a packet, the sender will take it as
>> + * a already sent packet, so sent_cb should not be called later.
> s/a already/an already/
>
next prev parent reply other threads:[~2015-09-28 6:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-25 8:08 [Qemu-devel] [PATCH v1] netfilter: various comment fixes Yang Hongyang
2015-09-25 8:12 ` Yang Hongyang
2015-09-25 14:30 ` Eric Blake
2015-09-28 6:13 ` Jason Wang [this message]
2015-09-25 15:33 ` Markus Armbruster
2015-09-28 6:15 ` Jason Wang
2015-09-28 6:28 ` Yang Hongyang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5608DA89.3080905@redhat.com \
--to=jasowang@redhat.com \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=yanghy@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).