From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39936) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZgRgm-0007rz-N9 for qemu-devel@nongnu.org; Mon, 28 Sep 2015 02:13:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZgRgl-0007YX-Ma for qemu-devel@nongnu.org; Mon, 28 Sep 2015 02:13:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47875) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZgRgl-0007YR-H7 for qemu-devel@nongnu.org; Mon, 28 Sep 2015 02:13:27 -0400 References: <1443168480-5067-1-git-send-email-yanghy@cn.fujitsu.com> <56055A7F.1090700@redhat.com> From: Jason Wang Message-ID: <5608DA89.3080905@redhat.com> Date: Mon, 28 Sep 2015 14:13:29 +0800 MIME-Version: 1.0 In-Reply-To: <56055A7F.1090700@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v1] netfilter: various comment fixes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , Yang Hongyang , qemu-devel@nongnu.org Cc: armbru@redhat.com On 09/25/2015 10:30 PM, Eric Blake wrote: > On 09/25/2015 02:08 AM, Yang Hongyang wrote: >> This patchset addressed Markus comment on netfilter patch >> series, most of them are comment fixes. >> >> It is based on jason's net tree: >> https://github.com/jasowang/qemu/tree/net > If that tree is not yet merged mainline, wouldn't it be better to squash > these fixes directly into the offending patches, instead of using it as > a followup patch? Yes, and maybe a new version. > >> /* >> - * we return size when buffer a packet, the sender will take it as >> - * a already sent packet, so sent_cb should not be called later >> - * FIXME: even if guest can't receive packet for some reasons. Filter >> + * We return size when buffer a packet, the sender will take it as >> + * a already sent packet, so sent_cb should not be called later. > s/a already/an already/ >