From: Paolo Bonzini <pbonzini@redhat.com>
To: Eric Blake <eblake@redhat.com>,
Shraddha Barke <shraddha.6596@gmail.com>,
kvm@vger.kernel.org, qemu-trivial@nongnu.org,
Michael Tokarev <mjt@tls.msk.ru>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH 3/3] Target-ppc: Remove unnecessary variable
Date: Mon, 28 Sep 2015 12:56:04 +0200 [thread overview]
Message-ID: <56091CC4.4020108@redhat.com> (raw)
In-Reply-To: <5606C4A1.60509@redhat.com>
On 26/09/2015 18:15, Eric Blake wrote:
> On 09/25/2015 02:37 AM, Shraddha Barke wrote:
>> Compress lines and remove the variable.
>>
>
>> +++ b/target-ppc/kvm.c
>> @@ -1782,8 +1782,7 @@ uint32_t kvmppc_get_tbfreq(void)
>>
>> ns++;
>>
>> - retval = atoi(ns);
>> - return retval;
>> + return atoi(ns);
>
> atoi() is lousy; it cannot properly detect user input errors. This
> should probably be converted to use the appropriate qemu_strtol variant
> instead.
But it's more or less okay here, it's parsing /proc/cpuinfo.
Paolo
next prev parent reply other threads:[~2015-09-28 10:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-25 8:37 [Qemu-devel] [PATCH 1/3] Target-microblaze: Remove unnecessary variable Shraddha Barke
2015-09-25 8:37 ` [Qemu-devel] [PATCH 2/3] Hw: timer: " Shraddha Barke
2015-09-25 21:35 ` Peter Maydell
2015-09-25 8:37 ` [Qemu-devel] [PATCH 3/3] Target-ppc: " Shraddha Barke
2015-09-26 16:15 ` Eric Blake
2015-09-28 10:56 ` Paolo Bonzini [this message]
2015-10-03 16:50 ` Michael Tokarev
2015-10-03 16:50 ` [Qemu-devel] [PATCH 1/3] Target-microblaze: " Michael Tokarev
2015-10-05 5:18 ` Markus Armbruster
2015-10-05 7:18 ` Michael Tokarev
2015-10-05 7:53 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56091CC4.4020108@redhat.com \
--to=pbonzini@redhat.com \
--cc=eblake@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mjt@tls.msk.ru \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=shraddha.6596@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).