From: Paolo Bonzini <pbonzini@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Thomas Huth <thuth@redhat.com>,
ehabkost@redhat.com,
Peter Crosthwaite <crosthwaite.peter@gmail.com>,
qemu-devel@nongnu.org, qemu-stable@nongnu.org,
Christian Borntraeger <borntraeger@de.ibm.com>,
Alexander Graf <agraf@suse.de>,
qemu-ppc@nongnu.org, Antony Pavlov <antonynpavlov@gmail.com>,
stefanha@redhat.com, Cornelia Huck <cornelia.huck@de.ibm.com>,
Alistair Francis <alistair.francis@xilinx.com>,
afaerber@suse.de, Li Guang <lig.fnst@cn.fujitsu.com>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH v3 6/7] qdev: Protect device-list-properties against broken devices
Date: Mon, 28 Sep 2015 16:25:23 +0200 [thread overview]
Message-ID: <56094DD3.2020505@redhat.com> (raw)
In-Reply-To: <87io6ud3wg.fsf@blackfin.pond.sub.org>
On 28/09/2015 16:17, Markus Armbruster wrote:
>> The reason why this particular call has a NULL owner is that the
>> (non-qdevified) DBDMA_init object inside it is also passing a NULL
>> owner. DBDMA_init object is also doing a few more non-idempotent things
>> such as a malloc, a vmstate_register and a qemu_register_reset.
I missed a step here: "... thus macio really
cannot_be_created_even_by_object_new_yet".
> * hw/misc/omap_gpmc.c omap_gpmc_cs_map()
>
> Is this sane? I guess the object_unparent() in omap_gpmc_cs_unmap()
> could make it sane.
>
> * hw/ppc/ppc4xx_devs.c sdram_set_bcr()
>
> Is this sane? I guess the object_unparent() there could make it sane.
Yes and yes.
There are many more similar places that you missed, which call
memory_region_init_alias(), memory_region_init_io() and
memory_region_init_ram(). Those are the same.
Paolo
next prev parent reply other threads:[~2015-09-28 14:25 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-24 18:57 [Qemu-devel] [PATCH v3 0/7] Fix device introspection regressions Markus Armbruster
2015-09-24 18:57 ` [Qemu-devel] [PATCH v3 1/7] tests: Fix how qom-test is run Markus Armbruster
2015-09-24 18:57 ` [Qemu-devel] [PATCH v3 2/7] libqtest: Clean up unused QTestState member sigact_old Markus Armbruster
2015-09-24 18:57 ` [Qemu-devel] [PATCH v3 3/7] libqtest: New hmp() & friends Markus Armbruster
2015-09-24 18:57 ` [Qemu-devel] [PATCH v3 4/7] device-introspect-test: New, covering device introspection Markus Armbruster
2015-09-25 10:17 ` Thomas Huth
2015-09-25 10:18 ` Andreas Färber
2015-09-25 14:13 ` Markus Armbruster
2015-09-24 18:57 ` [Qemu-devel] [PATCH v3 5/7] qmp: Fix device-list-properties not to crash for abstract device Markus Armbruster
2015-09-24 18:57 ` [Qemu-devel] [PATCH v3 6/7] qdev: Protect device-list-properties against broken devices Markus Armbruster
2015-09-24 19:25 ` Eduardo Habkost
2015-09-25 6:07 ` Markus Armbruster
2015-09-25 13:38 ` Thomas Huth
2015-09-25 14:17 ` Markus Armbruster
2015-09-25 18:21 ` Thomas Huth
2015-09-28 8:11 ` Markus Armbruster
2015-09-28 8:15 ` Andreas Färber
2015-09-28 8:38 ` Paolo Bonzini
2015-09-28 8:37 ` Paolo Bonzini
2015-09-28 14:17 ` Markus Armbruster
2015-09-28 14:25 ` Paolo Bonzini [this message]
2015-09-28 9:17 ` Thomas Huth
2015-09-28 9:30 ` Peter Maydell
2015-09-28 14:35 ` Markus Armbruster
2015-09-28 14:44 ` Peter Maydell
2015-09-28 19:36 ` Markus Armbruster
2015-09-28 19:40 ` Peter Maydell
2015-09-29 8:05 ` Markus Armbruster
2015-09-29 12:38 ` Paolo Bonzini
2015-09-24 18:57 ` [Qemu-devel] [PATCH v3 7/7] Revert "qdev: Use qdev_get_device_class() for -device <type>, help" Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56094DD3.2020505@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=alistair.francis@xilinx.com \
--cc=antonynpavlov@gmail.com \
--cc=armbru@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cornelia.huck@de.ibm.com \
--cc=crosthwaite.peter@gmail.com \
--cc=ehabkost@redhat.com \
--cc=lig.fnst@cn.fujitsu.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=rth@twiddle.net \
--cc=stefanha@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).