From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53693) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zga0g-0004eK-LI for qemu-devel@nongnu.org; Mon, 28 Sep 2015 11:06:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zga0b-0002or-Nc for qemu-devel@nongnu.org; Mon, 28 Sep 2015 11:06:34 -0400 References: <1443211950-8207-1-git-send-email-sw@weilnetz.de> <871tdjni3w.fsf@blackfin.pond.sub.org> <5608F9BC.603@weilnetz.de> From: Eric Blake Message-ID: <5609576F.2060407@redhat.com> Date: Mon, 28 Sep 2015 09:06:23 -0600 MIME-Version: 1.0 In-Reply-To: <5608F9BC.603@weilnetz.de> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="1eL7uoHSJVR8SDMPOuUXtAjEnWuCwM9nQ" Subject: Re: [Qemu-devel] [PATCH] trace/simple: Fix warning and wrong trace file name for MinGW List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil , Markus Armbruster Cc: QEMU Trivial , QEMU Developer , Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --1eL7uoHSJVR8SDMPOuUXtAjEnWuCwM9nQ Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/28/2015 02:26 AM, Stefan Weil wrote: >> Can you explain why osdep.h's >> >> #define FMT_pid "%" PRId64 >> >> is appropriate for Windows? >=20 > Don't blame me for any strangeness which you might find in Windows. :-)= >=20 > Mingw-w64 sys/types.h defines pid_t to be either an int or an __int64. > FMT_pid must match these definitions. >=20 > But getpid returns an int, not a pid_t... Can we 1) file a bug against mingw for their buggy getpid(), and 2) write a wrapper that makes getpid() always return pid_t in the meantime? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --1eL7uoHSJVR8SDMPOuUXtAjEnWuCwM9nQ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWCVdvAAoJEKeha0olJ0NqkVYIAJBcxwB0pi4t6TEOpxFafhic dbiRIVD6im6PCnFWJk33YPwMbhO+nINPDH0L8SMtDT2X95cSmH4eMBhZd3PS46uv rJoT+V2QOnQbNPTNlfcbLRKSbIkYW6EVvvOtRUGnUTk8R0Y4kuB1H+LE1a0YyxKf PWR1GYTpdmDsMvdqP/0UqpzmuQmQQvWkVVFlyowU0gHQJqdlGkK1Xe/lQLBDswa6 rpB0S0zb2EQxNt/fQ2hDtFYOiJLXS/WRIi3PYXPSZE/33Pxyy+UJbEwETR9rEaYa zYgt4KzN4ylHJRYl23KNLncQ4kU6ARI98ty4h2TsFGyJ+V7T6sLkdfh+czePWqA= =yGVi -----END PGP SIGNATURE----- --1eL7uoHSJVR8SDMPOuUXtAjEnWuCwM9nQ--