From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57720) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zga9T-0004rz-2N for qemu-devel@nongnu.org; Mon, 28 Sep 2015 11:15:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zga9O-0006au-3d for qemu-devel@nongnu.org; Mon, 28 Sep 2015 11:15:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54477) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zga9N-0006an-UB for qemu-devel@nongnu.org; Mon, 28 Sep 2015 11:15:34 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 83981C0798E1 for ; Mon, 28 Sep 2015 15:15:33 +0000 (UTC) References: <1443189647-11417-1-git-send-email-armbru@redhat.com> <1443189647-11417-7-git-send-email-armbru@redhat.com> <5605A17F.1090001@redhat.com> <87vbavkkfg.fsf@blackfin.pond.sub.org> From: Eric Blake Message-ID: <56095994.8010300@redhat.com> Date: Mon, 28 Sep 2015 09:15:32 -0600 MIME-Version: 1.0 In-Reply-To: <87vbavkkfg.fsf@blackfin.pond.sub.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="gs3C739XSqfWIUpOn3xuTXWQWwhES6LlX" Subject: Re: [Qemu-devel] [RFC 6/6] docs: Document QMP event rate limiting List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: amit.shah@redhat.com, marcandre.lureau@redhat.com, lersek@redhat.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --gs3C739XSqfWIUpOn3xuTXWQWwhES6LlX Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/28/2015 02:38 AM, Markus Armbruster wrote: >>> +++ b/docs/qmp/qmp-spec.txt >>> @@ -175,6 +175,11 @@ The format of asynchronous events is: >>> For a listing of supported asynchronous events, please, refer to the= >>> qmp-events.txt file. >>> =20 >>> +Some events are rate-limited to at most one per second. If more >>> +events arrive within one second, all but the last one are dropped, a= nd >>> +the last one is delayed. Rate-limiting applies to each kind of even= t >>> +separately. >> >> Do we also want to document that limits might be further tuned accordi= ng >> to other elements of the event, with VSERPORT_CHANGE "id" as the examp= le? >=20 > You need to interpret "each kind of event" in a sufficiently fuzzy > manner :) >=20 > Seriously, I'm open to suggestions for better language here. Maybe: Some events are rate-limited to at most one per second. If more events of the same type (along with any other fields that an event documents as being significant) arrive within one second, ... or: Some events are rate-limited to at most one per second, either for the event type in general, or additionally considering other significant fields as documented by a specific event. If more equivalent events arrive within one second, ... But since you did point out that VSERPORT_CHANGE mentions the filtering on "id", I guess I won't try too much harder to paint the bikeshed any further. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --gs3C739XSqfWIUpOn3xuTXWQWwhES6LlX Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWCVmUAAoJEKeha0olJ0NqxDQH/RIlgWi3AAMeT16iEtO2BkFA dildOUCGr8ifchDil7QyS9Ps2s9FSVLZ1C8b1c/hgVd1WaTP6zwu7aDgXYNog4A4 wg8c9NGnYoawxf7I8Xrymmej+1pmjEjsLFqbbAfq0p7ofAw+oV3eN+ljxkA9gIzp XwO7IRiN8w1pJZh/ZXaK5JEWSbOQFCilf5a/bVgJAzroK0LqOK9iUnRAbndjO152 e4oqAbQ9koojf6FrCS1AksL2r9sLzZIAWvDt1moK1BMJkioa/NSsGt7KfdY0r91o /n+CASoLP9j4r/OEapPSfu3Pr7ILOGKDVPOJEcAcU6c3zZp+XpNLUzaNy5dC7To= =4LjU -----END PGP SIGNATURE----- --gs3C739XSqfWIUpOn3xuTXWQWwhES6LlX--