From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48366)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1ZgeNn-0008Vs-R6
	for qemu-devel@nongnu.org; Mon, 28 Sep 2015 15:46:44 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1ZgeNk-00016N-Ex
	for qemu-devel@nongnu.org; Mon, 28 Sep 2015 15:46:43 -0400
Received: from mx1.redhat.com ([209.132.183.28]:39824)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1ZgeNk-00016H-AG
	for qemu-devel@nongnu.org; Mon, 28 Sep 2015 15:46:40 -0400
References: <1443308129-19965-1-git-send-email-somlo@cmu.edu>
	<560940F4.2010003@redhat.com>
From: Eric Blake <eblake@redhat.com>
Message-ID: <56099919.10704@redhat.com>
Date: Mon, 28 Sep 2015 13:46:33 -0600
MIME-Version: 1.0
In-Reply-To: <560940F4.2010003@redhat.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature";
	boundary="2rqMJ56Gud2TgkWQrstNINQ2wVs2TpqPh"
Subject: Re: [Qemu-devel] [PATCH] fw_cfg: insert string blobs via qemu
	cmdline
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Laszlo Ersek <lersek@redhat.com>, "Gabriel L. Somlo" <somlo@cmu.edu>, qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, jordan.l.justen@intel.com

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--2rqMJ56Gud2TgkWQrstNINQ2wVs2TpqPh
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On 09/28/2015 07:30 AM, Laszlo Ersek wrote:

>> =20
>> +Small enough items may be provided directly as strings on the command=

>> +line, using the syntax:
>> +
>> +    -fw_cfg [name=3D]<item_name>,content=3D<string>
>> +
>=20
> Please consider spelling out that these blobs will NOT be NUL-terminate=
d
> when viewed on the guest. (It kinda follows from all the other fw_cfg
> things, but once we leave host-side files for qemu command line strings=
,
> it might become non-obvious to users.)

Or else GUARANTEE that it will be NUL-terminated (and the only way to
get blobs that are not NUL terminated is to use files rather than content=
=3D).

--=20
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


--2rqMJ56Gud2TgkWQrstNINQ2wVs2TpqPh
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
Comment: Public key at http://people.redhat.com/eblake/eblake.gpg
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBCAAGBQJWCZkZAAoJEKeha0olJ0NqUnoH/RlRmWfWXTi+ScY7YpfS1Me7
uIY/8PZYpGnThiGcoMV8a0molI3+HzZhdTQSAZifOSOJ07NEPuwkOmLTmgdt2VA9
PaeR0RRVFG9GLfGNJlt+03n8SJrcjaBPgVm8wHJRjPMvr3fZNI5oqlxFy3z1F2f/
ZHaUXVn9rAOfVMGYHelsaFhiBkqSq2Rw6UQwto0ebs6z3eR9Pt1FETz2r9NfwYga
fWRqfzFhliMKbL5uzYzH18KkE3+0PKgmP2N0tOwcZGYWCs+SxtzwToSOg5jUU/yZ
ahwToWLG8toVMMBPQBBsZuCz6guoCW2Uo5jtZmD/EJOA7F2iwVAJUXNFGx7zEa8=
=1smW
-----END PGP SIGNATURE-----

--2rqMJ56Gud2TgkWQrstNINQ2wVs2TpqPh--