From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38997) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZglOz-000644-7k for qemu-devel@nongnu.org; Mon, 28 Sep 2015 23:16:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZglOv-0000MJ-VD for qemu-devel@nongnu.org; Mon, 28 Sep 2015 23:16:25 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38865) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZglOv-0000MF-Pe for qemu-devel@nongnu.org; Mon, 28 Sep 2015 23:16:21 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 831B0A453C for ; Tue, 29 Sep 2015 03:16:20 +0000 (UTC) References: <1443418828-11690-1-git-send-email-jasowang@redhat.com> <87eghily5e.fsf@blackfin.pond.sub.org> From: Jason Wang Message-ID: <560A0281.4030806@redhat.com> Date: Tue, 29 Sep 2015 11:16:17 +0800 MIME-Version: 1.0 In-Reply-To: <87eghily5e.fsf@blackfin.pond.sub.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] e1000: use alias for default model List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel@nongnu.org On 09/28/2015 04:57 PM, Markus Armbruster wrote: > Jason Wang writes: > >> Instead of using a new type for default model (82540em), using an >> alias for this to avoid bit duplication. > Suggest to rephrase as > > Instead of duplicating the "e1000-82540em" device model as "e1000", > make the latter an alias for the former. Fix like this and apply the patch in my tree. > >> Cc: Markus Armbruster >> Signed-off-by: Jason Wang > Reviewed-by: Markus Armbruster Thanks.