From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36602)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <thuth@redhat.com>) id 1Zgojt-0002eZ-VO
	for qemu-devel@nongnu.org; Tue, 29 Sep 2015 02:50:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <thuth@redhat.com>) id 1Zgojo-0001ri-Vg
	for qemu-devel@nongnu.org; Tue, 29 Sep 2015 02:50:13 -0400
References: <1443470907-32335-1-git-send-email-armbru@redhat.com>
	<1443470907-32335-6-git-send-email-armbru@redhat.com>
From: Thomas Huth <thuth@redhat.com>
Message-ID: <560A349A.5090506@redhat.com>
Date: Tue, 29 Sep 2015 08:50:02 +0200
MIME-Version: 1.0
In-Reply-To: <1443470907-32335-6-git-send-email-armbru@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v4 5/7] qmp: Fix device-list-properties not
 to crash for abstract device
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-stable@nongnu.org, afaerber@suse.de, stefanha@redhat.com, ehabkost@redhat.com

On 28/09/15 22:08, Markus Armbruster wrote:
> Broken in commit f4eb32b "qmp: show QOM properties in
> device-list-properties", v2.1.
> 
> Cc: qemu-stable@nongnu.org
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> Reviewed-by: Eric Blake <eblake@redhat.com>
> ---
>  qmp.c                          |  6 ++++++
>  tests/device-introspect-test.c | 15 ++++-----------
>  2 files changed, 10 insertions(+), 11 deletions(-)
> 
> diff --git a/qmp.c b/qmp.c
> index 057a7cb..1413de4 100644
> --- a/qmp.c
> +++ b/qmp.c
> @@ -515,6 +515,12 @@ DevicePropertyInfoList *qmp_device_list_properties(const char *typename,
>          return NULL;
>      }
>  
> +    if (object_class_is_abstract(klass)) {
> +        error_setg(errp, QERR_INVALID_PARAMETER_VALUE, "name",
> +                   "non-abstract device type");
> +        return NULL;
> +    }
> +
>      obj = object_new(typename);
>  
>      QTAILQ_FOREACH(prop, &obj->properties, node) {
> diff --git a/tests/device-introspect-test.c b/tests/device-introspect-test.c
> index 832b60a..a8950a1 100644
> --- a/tests/device-introspect-test.c
> +++ b/tests/device-introspect-test.c
> @@ -45,17 +45,10 @@ static void test_one_device(const char *type)
>      QDict *resp;
>      char *help, *qom_tree;
>  
> -    /*
> -     * Skip this part for the abstract device test case, because
> -     * device-list-properties crashes for such devices.
> -     * FIXME fix it not to crash
> -     */
> -    if (strcmp(type, "device")) {
> -        resp = qmp("{'execute': 'device-list-properties',"
> -                   " 'arguments': {'typename': %s}}",
> -                   type);
> -        QDECREF(resp);
> -    }
> +    resp = qmp("{'execute': 'device-list-properties',"
> +               " 'arguments': {'typename': %s}}",
> +               type);
> +    QDECREF(resp);
>  
>      help = hmp("device_add \"%s,help\"", type);
>      g_free(help);
> 

Why don't you fix this before patch 4/7, then you don't have to add the
temporary work-around in device-introspect-test.c ?

 Thomas