From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46430) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zgp8y-00024s-DH for qemu-devel@nongnu.org; Tue, 29 Sep 2015 03:16:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zgp8u-00054S-Ef for qemu-devel@nongnu.org; Tue, 29 Sep 2015 03:16:08 -0400 References: <1443069231-14856-1-git-send-email-david@gibson.dropbear.id.au> <1443069231-14856-6-git-send-email-david@gibson.dropbear.id.au> <56052DEC.6040500@redhat.com> <20150925113349.GL11620@voom.redhat.com> <5605383E.1090406@redhat.com> <20150926065414.GM11620@voom.redhat.com> <56090157.2000903@redhat.com> <20150929033033.GA19428@voom.redhat.com> From: Paolo Bonzini Message-ID: <560A3AAE.7070005@redhat.com> Date: Tue, 29 Sep 2015 09:15:58 +0200 MIME-Version: 1.0 In-Reply-To: <20150929033033.GA19428@voom.redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 5/7] memory: Allow replay of IOMMU mapping notifications List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Gibson Cc: lvivier@redhat.com, thuth@redhat.com, qemu-devel@nongnu.org, abologna@redhat.com, alex.williamson@redhat.com, qemu-ppc@nongnu.org On 29/09/2015 05:30, David Gibson wrote: >> Maybe... The only issue is the "granularity" argument, which is >> not in memory_region_register_iommu_notifier. That makes me >> wonder if the replay and registration make sense as separate >> operations. >> >> What about adding a new function memory_region_iommu_replay and >> separate the two phases? > > Hm.. I'm not sure I see much advantage to separating the phases. It's just that it's (IMO) the clearest API. It shows how the granularity is only used for replay. > But I don't particularly object to the idea either. So, I think it's your > call. Yes, let's separate it. Thanks, Paolo