From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57808)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1ZguBW-0003TP-CD
	for qemu-devel@nongnu.org; Tue, 29 Sep 2015 08:39:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1ZguBS-0002BN-LN
	for qemu-devel@nongnu.org; Tue, 29 Sep 2015 08:39:06 -0400
References: <1443121042-3409-1-git-send-email-armbru@redhat.com>
	<1443121042-3409-7-git-send-email-armbru@redhat.com>
	<56054E5E.3090005@redhat.com> <87y4fu1t3j.fsf@blackfin.pond.sub.org>
	<560590A6.3030408@redhat.com> <87io6vm08l.fsf@blackfin.pond.sub.org>
	<560905C5.2030209@redhat.com> <87fv1ybohq.fsf@blackfin.pond.sub.org>
	<87lhbq1glx.fsf@blackfin.pond.sub.org>
	<CAFEAcA__VJA1qPRw9uM-rfbfn7fFbc1XXRg2sYCMvrex2WrJKA@mail.gmail.com>
	<87d1x1sla0.fsf@blackfin.pond.sub.org>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <560A8654.8010404@redhat.com>
Date: Tue, 29 Sep 2015 14:38:44 +0200
MIME-Version: 1.0
In-Reply-To: <87d1x1sla0.fsf@blackfin.pond.sub.org>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 6/7] qdev: Protect
 device-list-properties against broken devices
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>, Peter Maydell <peter.maydell@linaro.org>
Cc: Thomas Huth <thuth@redhat.com>, Eduardo Habkost <ehabkost@redhat.com>, Peter Crosthwaite <crosthwaite.peter@gmail.com>, qemu-stable <qemu-stable@nongnu.org>, QEMU Developers <qemu-devel@nongnu.org>, Alexander Graf <agraf@suse.de>, Christian Borntraeger <borntraeger@de.ibm.com>, "qemu-ppc@nongnu.org" <qemu-ppc@nongnu.org>, Antony Pavlov <antonynpavlov@gmail.com>, Stefan Hajnoczi <stefanha@redhat.com>, Cornelia Huck <cornelia.huck@de.ibm.com>, Alistair Francis <alistair.francis@xilinx.com>, =?UTF-8?Q?Andreas_F=c3=a4rber?= <afaerber@suse.de>, Li Guang <lig.fnst@cn.fujitsu.com>, Richard Henderson <rth@twiddle.net>

On 2/09/2015 10:05, Markus Armbruster wrote:
> > > 1. I made device-introspection-test run "info qom-tree", which has a
> > >    lovely propensity to crash when a crappy device left dangling pointer
> > >    behind.  This led me to "cgthree", "cuda", "integrator_debug",
> > >    "macio-oldworld", "macio-newworld", "pxa2xx-fir", "SUNW,tcx".  They
> > >    all create memory regions without owner in their instance_init()
> > >    method.
> >
> > I guess these are all just "oops, we forgot to pass the Object* in
> > instead of NULL" bugs rather than more difficult fixes.
>
> I'm leaving the actual fixing to people with a better understanding of
> these devices, and ability to actually test them.

Gave it a shot...

Paolo