From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42665) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZguiZ-0004b3-6I for qemu-devel@nongnu.org; Tue, 29 Sep 2015 09:13:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZguiV-0002Hk-0k for qemu-devel@nongnu.org; Tue, 29 Sep 2015 09:13:15 -0400 Received: from lhrrgout.huawei.com ([194.213.3.17]:50103) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZguiU-0002HL-PJ for qemu-devel@nongnu.org; Tue, 29 Sep 2015 09:13:10 -0400 References: <1443094669-4144-1-git-send-email-marcandre.lureau@redhat.com> <1443094669-4144-2-git-send-email-marcandre.lureau@redhat.com> From: Claudio Fontana Message-ID: <560A8E5E.3060208@huawei.com> Date: Tue, 29 Sep 2015 15:13:02 +0200 MIME-Version: 1.0 In-Reply-To: <1443094669-4144-2-git-send-email-marcandre.lureau@redhat.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH v4 01/47] char: add qemu_chr_free() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: marcandre.lureau@redhat.com, qemu-devel@nongnu.org Cc: pbonzini@redhat.com, drjones@redhat.com, cam@cs.ualberta.ca, stefanha@redhat.com On 24.09.2015 13:37, marcandre.lureau@redhat.com wrote: > From: Marc-André Lureau > > If a chardev is allowed to be created outside of QMP, then it must be > also possible to free it. This is useful for ivshmem that creates > chardev anonymously and must be able to free them. > > Signed-off-by: Marc-André Lureau > Acked-by: Paolo Bonzini > --- > include/sysemu/char.h | 10 +++++++++- > qemu-char.c | 9 +++++++-- > 2 files changed, 16 insertions(+), 3 deletions(-) > > diff --git a/include/sysemu/char.h b/include/sysemu/char.h > index 832b7fe..5fd0a09 100644 > --- a/include/sysemu/char.h > +++ b/include/sysemu/char.h > @@ -128,11 +128,19 @@ CharDriverState *qemu_chr_new(const char *label, const char *filename, > /** > * @qemu_chr_delete: > * > - * Destroy a character backend. > + * Destroy a character backend and remove it from the list of > + * identified character backends. > */ > void qemu_chr_delete(CharDriverState *chr); > > /** > + * @qemu_chr_free: > + * > + * Destroy a character backend. > + */ > +void qemu_chr_free(CharDriverState *chr); > + > +/** > * @qemu_chr_fe_set_echo: > * > * Ask the backend to override its normal echo setting. This only really > diff --git a/qemu-char.c b/qemu-char.c > index 653ea10..e6ed85c 100644 > --- a/qemu-char.c > +++ b/qemu-char.c > @@ -3840,9 +3840,8 @@ void qemu_chr_fe_release(CharDriverState *s) > s->avail_connections++; > } > > -void qemu_chr_delete(CharDriverState *chr) > +void qemu_chr_free(CharDriverState *chr) > { > - QTAILQ_REMOVE(&chardevs, chr, next); > if (chr->chr_close) { > chr->chr_close(chr); > } > @@ -3852,6 +3851,12 @@ void qemu_chr_delete(CharDriverState *chr) > g_free(chr); > } > > +void qemu_chr_delete(CharDriverState *chr) > +{ > + QTAILQ_REMOVE(&chardevs, chr, next); > + qemu_chr_free(chr); > +} > + > ChardevInfoList *qmp_query_chardev(Error **errp) > { > ChardevInfoList *chr_list = NULL; > Reviewed-by: Claudio Fontana