From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40036) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZgwV4-0000zx-SU for qemu-devel@nongnu.org; Tue, 29 Sep 2015 11:07:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZgwV0-0005lY-Mf for qemu-devel@nongnu.org; Tue, 29 Sep 2015 11:07:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46133) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZgwV0-0005kW-GU for qemu-devel@nongnu.org; Tue, 29 Sep 2015 11:07:22 -0400 References: <1443497249-15361-1-git-send-email-eblake@redhat.com> <1443497249-15361-15-git-send-email-eblake@redhat.com> <87612tiads.fsf@blackfin.pond.sub.org> From: Eric Blake Message-ID: <560AA926.40602@redhat.com> Date: Tue, 29 Sep 2015 09:07:18 -0600 MIME-Version: 1.0 In-Reply-To: <87612tiads.fsf@blackfin.pond.sub.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Jqu1TjJDIC426LP0GNlK8xBo1vrsvJjQ1" Subject: Re: [Qemu-devel] [PATCH v6 14/16] qapi: Consistent generated code: minimize push_indent() usage List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: marcandre.lureau@redhat.com, qemu-devel@nongnu.org, ehabkost@redhat.com, Michael Roth This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Jqu1TjJDIC426LP0GNlK8xBo1vrsvJjQ1 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/29/2015 08:10 AM, Markus Armbruster wrote: > Eric Blake writes: >=20 >> We had some pointless differences in the generated code for visit, >> command marshalling, and events; unifying them makes it easier for >> future patches to consolidate to common helper functions. >> >> This patch makes no difference to the generated code, but rather >> focuses on reducing the number of push_indent()/pop_indent() pairs >> so that generated code is typically already at its natural output >> indentation in the python files. It is easier to reason about >> generated code if the reader does not have to track how much >> spacing will be inserted alongside the code, and moreso when all >> of the generators use the same patterns (qapi-type and qapi-event >> were already using in-place indentation). >> >> Signed-off-by: Eric Blake >=20 > A few places become slightly less readable because the generated code i= s > now indented lile the surrounding Python code. Other places become mor= e > readable. Having to think less about push_indent() / pop_indent() tips= > the balance, I guess. >=20 > Have you diffed the generated code before and after the patch? Yes; quoting above: >> This patch makes no difference to the generated code, --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --Jqu1TjJDIC426LP0GNlK8xBo1vrsvJjQ1 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWCqknAAoJEKeha0olJ0Nqpe8IAIZwuofd7WUogTDZKjNZ9l88 JjUjDriO5sXKqqAOZJxrl5lnNY+TUiZ+7puG9QW4CBaEvpA/5KY8pV4yVXkgPUiT N29qNy1G9zJPK6iquE08G/RMm6TQEr8F1U8ejGm9FtLaDaBznag0dlbzCw4q2Yaq lFdJ9cxVVdDK6tjAP1YnsfymOfh4Xs9NMxPpN961OulVhxWZuVN+dojXZwG8Sgnb vSZvpiiw+3wzlX5QCar88HBzO8F8WENMN0PaIenPYRlLAXoShfpUnuGa1kuQpb5q vbS8WaB9CPc2vidTPzHKL+a7ucC25fyDE+Tmdses+Ib33EFytHLbQX0KT4VTFyE= =qwlE -----END PGP SIGNATURE----- --Jqu1TjJDIC426LP0GNlK8xBo1vrsvJjQ1--