From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35053) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZgxQ3-0003sY-GP for qemu-devel@nongnu.org; Tue, 29 Sep 2015 12:06:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZgxQ0-0001Vr-0c for qemu-devel@nongnu.org; Tue, 29 Sep 2015 12:06:19 -0400 Received: from mx2.suse.de ([195.135.220.15]:42108) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZgxPz-0001VX-Qn for qemu-devel@nongnu.org; Tue, 29 Sep 2015 12:06:15 -0400 References: <1443470907-32335-1-git-send-email-armbru@redhat.com> <1443470907-32335-2-git-send-email-armbru@redhat.com> From: =?UTF-8?Q?Andreas_F=c3=a4rber?= Message-ID: <560AB6F5.4080308@suse.de> Date: Tue, 29 Sep 2015 18:06:13 +0200 MIME-Version: 1.0 In-Reply-To: <1443470907-32335-2-git-send-email-armbru@redhat.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v4 1/7] tests: Fix how qom-test is run List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: thuth@redhat.com, ehabkost@redhat.com, stefanha@redhat.com Am 28.09.2015 um 22:08 schrieb Markus Armbruster: > We want to run qom-test for every architecture, without having to > manually add it to every architecture's list of tests. Commit 3687d53 > accomplished this by adding it to every architecture's list > automatically. >=20 > However, some architectures inherit their tests from others, like this: >=20 > check-qtest-x86_64-y =3D $(check-qtest-i386-y) > check-qtest-microblazeel-y =3D $(check-qtest-microblaze-y) > check-qtest-xtensaeb-y =3D $(check-qtest-xtensa-y) >=20 > For such architectures, we ended up running the (slow!) test twice. > Commit 2b8419c attempted to avoid this by adding the test only when > it's not already present. Works only as long as we consider adding > the test to the architectures on the left hand side *after* the ones > on the right hand side: x86_64 after i386, microblazeel after > microblaze, xtensaeb after xtensa. >=20 > Turns out we consider them in $(SYSEMU_TARGET_LIST) order. Defined as >=20 > SYSEMU_TARGET_LIST :=3D $(subst -softmmu.mak,,$(notdir \ > $(wildcard $(SRC_PATH)/default-configs/*-softmmu.mak))) >=20 > On my machine, this results in the oder xtensa, x86_64, microblazeel, > microblaze, i386. Consequently, qom-test runs twice for microblazeel > and x86_64. >=20 > Replace this complex and flawed machinery with a much simpler one: add > generic tests (currently just qom-test) to check-qtest-generic-y > instead of check-qtest-$(target)-y for every target, then run > $(check-qtest-generic-y) for every target. >=20 > Signed-off-by: Markus Armbruster > --- > tests/Makefile | 14 ++++++++------ > 1 file changed, 8 insertions(+), 6 deletions(-) Looks good to me, Reviewed-by: Andreas F=E4rber However one comment regarding your commit message: You missed that I proposed a different patch before Peter committed his. I wonder whether mine had the same issue... BTW there's an old patch from Stefan H. on the list (that I have on my queue to revisit, help appreciated), to make QTests more verbose even without V=3D1. Regards, Andreas --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Felix Imend=F6rffer, Jane Smithard, Graham Norton; HRB 21284 (AG N=FC= rnberg)