From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33985) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zh1ax-0005V4-5X for qemu-devel@nongnu.org; Tue, 29 Sep 2015 16:33:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zh1as-0006eI-6a for qemu-devel@nongnu.org; Tue, 29 Sep 2015 16:33:51 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33336) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zh1as-0006e1-1Q for qemu-devel@nongnu.org; Tue, 29 Sep 2015 16:33:46 -0400 References: <1443497249-15361-1-git-send-email-eblake@redhat.com> <1443497249-15361-16-git-send-email-eblake@redhat.com> <87zj05guv8.fsf@blackfin.pond.sub.org> From: Eric Blake Message-ID: <560AF5A4.3000807@redhat.com> Date: Tue, 29 Sep 2015 14:33:40 -0600 MIME-Version: 1.0 In-Reply-To: <87zj05guv8.fsf@blackfin.pond.sub.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Bxg2gg8KstjHXsBqihCt8m71fpmHsJLUR" Subject: Re: [Qemu-devel] [PATCH v6 15/16] qapi: Share gen_err_check() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: marcandre.lureau@redhat.com, qemu-devel@nongnu.org, ehabkost@redhat.com, Michael Roth This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Bxg2gg8KstjHXsBqihCt8m71fpmHsJLUR Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/29/2015 08:31 AM, Markus Armbruster wrote: >=20 > To really cut the verbosity, I figure we'd have to do something more > radical, like having cgen() recognize a (short!) pattern and replace it= > with a full-blown error check. Not sure that's actually a good idea, > though :) Another radical idea would be write the python code to not care about whitespace or indentation discrepancies, because we instead run things through 'indent' as part of the code generation. Then we can emit ugly code without caring about indentation or multi-line, if it makes the python easier to write, and the output would still be nicely formatted. I'm not sure I want to do that, though. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --Bxg2gg8KstjHXsBqihCt8m71fpmHsJLUR Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWCvWkAAoJEKeha0olJ0NqWHkIAIEmxBrkIHIW7Pv2POl0IsUh jjUTN5y/ITQVMcvWCZ+qlCx822m+caHPPuFHwxPoMryM23nfTQmnCGzABQDBOjvM 9iGfiFsOk+NRoh9ZbafMf13QhqqxSqh6LBtOzMIFGQIZ8FbPHefoqfo5AZEu45JT Gi7yo5Bxhyiu4Xshd0BiTS+UZbECAwMvZfliO41Ae+y55JuQpTI9dkASg4xal+b0 Lo+xLzktLX4gYjfU0TPLin1liDB4uujpE+ENUV+XmM+GxxbnwOqfNjWIfkb0xB+J LpPjh1dQWjPFLpn2TPlWAzwlKMtIAokL3M0J+HSdpiQ8QcOMoKN4gOEpiZfMZO8= =W+Gh -----END PGP SIGNATURE----- --Bxg2gg8KstjHXsBqihCt8m71fpmHsJLUR--