From: Paolo Bonzini <pbonzini@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: peter.maydell@linaro.org, mark.cave-ayland@ilande.co.uk,
qemu-devel@nongnu.org, agraf@suse.de, blauwirbel@gmail.com,
qemu-ppc@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/3] hw: do not pass NULL to memory_region_init from instance_init
Date: Wed, 30 Sep 2015 15:03:43 +0200 [thread overview]
Message-ID: <560BDDAF.4070408@redhat.com> (raw)
In-Reply-To: <87eghg8etz.fsf@blackfin.pond.sub.org>
On 30/09/2015 10:57, Markus Armbruster wrote:
> Paolo Bonzini <pbonzini@redhat.com> writes:
>
>> > This causes the region to outlive the object, because it attaches the
>> > region to /machine. This is not nice for the "realize" method, but
>> > much worse for "instance_init" because it can cause dangling pointers
>> > after a simple object_new/object_unref pair.
>> >
>> > Reported-by: Markus Armbruster <armbru@redhat.com>
>> > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> One more: pxa2xx_pcmcia_initfn().
>
> The ones you fix are
> Tested-by: Markus Armbruster <armbru@redhat.com>
Can you fix it up and take it through your series?
Paolo
next prev parent reply other threads:[~2015-09-30 13:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-29 12:37 [Qemu-devel] [PATCH 0/3] Fix dangling pointers from memory_region_init_* Paolo Bonzini
2015-09-29 12:37 ` [Qemu-devel] [PATCH 1/3] memory: allow destroying a non-empty MemoryRegion Paolo Bonzini
2015-09-29 12:37 ` [Qemu-devel] [PATCH 2/3] hw: do not pass NULL to memory_region_init from instance_init Paolo Bonzini
2015-09-29 12:42 ` Peter Maydell
2015-09-30 8:30 ` Thomas Huth
2015-09-30 13:04 ` Paolo Bonzini
2015-10-01 7:39 ` Markus Armbruster
2015-10-01 8:26 ` Markus Armbruster
2015-10-01 9:27 ` Peter Maydell
2015-09-30 8:57 ` Markus Armbruster
2015-09-30 13:03 ` Paolo Bonzini [this message]
2015-10-01 7:39 ` Markus Armbruster
2015-10-01 10:13 ` Paolo Bonzini
2015-10-01 9:38 ` Mark Cave-Ayland
2015-09-29 12:37 ` [Qemu-devel] [PATCH 3/3] macio: move DBDMA_init from instance_init to realize Paolo Bonzini
2015-09-30 8:33 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=560BDDAF.4070408@redhat.com \
--to=pbonzini@redhat.com \
--cc=agraf@suse.de \
--cc=armbru@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).