From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57531) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZhH34-0001pK-LC for qemu-devel@nongnu.org; Wed, 30 Sep 2015 09:03:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZhH2z-0005jP-VK for qemu-devel@nongnu.org; Wed, 30 Sep 2015 09:03:54 -0400 References: <1443530263-32340-1-git-send-email-pbonzini@redhat.com> <1443530263-32340-3-git-send-email-pbonzini@redhat.com> <87eghg8etz.fsf@blackfin.pond.sub.org> From: Paolo Bonzini Message-ID: <560BDDAF.4070408@redhat.com> Date: Wed, 30 Sep 2015 15:03:43 +0200 MIME-Version: 1.0 In-Reply-To: <87eghg8etz.fsf@blackfin.pond.sub.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/3] hw: do not pass NULL to memory_region_init from instance_init List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: peter.maydell@linaro.org, mark.cave-ayland@ilande.co.uk, qemu-devel@nongnu.org, agraf@suse.de, blauwirbel@gmail.com, qemu-ppc@nongnu.org On 30/09/2015 10:57, Markus Armbruster wrote: > Paolo Bonzini writes: > >> > This causes the region to outlive the object, because it attaches the >> > region to /machine. This is not nice for the "realize" method, but >> > much worse for "instance_init" because it can cause dangling pointers >> > after a simple object_new/object_unref pair. >> > >> > Reported-by: Markus Armbruster >> > Signed-off-by: Paolo Bonzini > One more: pxa2xx_pcmcia_initfn(). > > The ones you fix are > Tested-by: Markus Armbruster Can you fix it up and take it through your series? Paolo