From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57672) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZhH3X-0001xZ-9d for qemu-devel@nongnu.org; Wed, 30 Sep 2015 09:04:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZhH3S-0005qU-Ic for qemu-devel@nongnu.org; Wed, 30 Sep 2015 09:04:23 -0400 References: <1443530263-32340-1-git-send-email-pbonzini@redhat.com> <1443530263-32340-3-git-send-email-pbonzini@redhat.com> <560B9DB4.8080707@redhat.com> From: Paolo Bonzini Message-ID: <560BDDCC.9070307@redhat.com> Date: Wed, 30 Sep 2015 15:04:12 +0200 MIME-Version: 1.0 In-Reply-To: <560B9DB4.8080707@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/3] hw: do not pass NULL to memory_region_init from instance_init List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, mark.cave-ayland@ilande.co.uk, agraf@suse.de, armbru@redhat.com, blauwirbel@gmail.com, qemu-ppc@nongnu.org On 30/09/2015 10:30, Thomas Huth wrote: >> > @@ -944,7 +944,7 @@ static void tcx_initfn(Object *obj) >> > SysBusDevice *sbd = SYS_BUS_DEVICE(obj); >> > TCXState *s = TCX(obj); >> > >> > - memory_region_init_ram(&s->rom, NULL, "tcx.prom", FCODE_MAX_ROM_SIZE, >> > + memory_region_init_ram(&s->rom, OBJECT(s), "tcx.prom", FCODE_MAX_ROM_SIZE, >> > &error_fatal); > Why "OBJECT(s)" and not simply "obj" ? No particular reason, just the way my brain worked. :) Paolo