From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49544) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZhIjh-0004W0-CB for qemu-devel@nongnu.org; Wed, 30 Sep 2015 10:52:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZhIjd-0002QT-CL for qemu-devel@nongnu.org; Wed, 30 Sep 2015 10:52:01 -0400 References: <1442497700-2536-1-git-send-email-kwolf@redhat.com> <1442497700-2536-10-git-send-email-kwolf@redhat.com> From: Max Reitz Message-ID: <560BF6FF.6010501@redhat.com> Date: Wed, 30 Sep 2015 16:51:43 +0200 MIME-Version: 1.0 In-Reply-To: <1442497700-2536-10-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="3AKgk7LDSLexxAuTxFUCxQQgOEHAFOLtv" Subject: Re: [Qemu-devel] [PATCH 09/16] block: Split bdrv_move_feature_fields() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: jcody@redhat.com, berto@igalia.com, armbru@redhat.com, stefanha@redhat.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --3AKgk7LDSLexxAuTxFUCxQQgOEHAFOLtv Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable On 17.09.2015 15:48, Kevin Wolf wrote: > After bdrv_swap(), some fields must be moved back to their original BDS= > to compensate for the effects that a swap of the contents of the object= s > has while keeping the old addresses. Other fields must be moved back > because they should logically be moved and must stay on top >=20 > When replacing bdrv_swap() with operations changing the pointers in the= > parents, we only need the latter and must avoid swapping the former. > Split the function accordingly. >=20 > Signed-off-by: Kevin Wolf > --- > block.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) Reviewed-by: Max Reitz (and an ACK to "Op blockers are a mess.") --3AKgk7LDSLexxAuTxFUCxQQgOEHAFOLtv Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWC/b/AAoJEDuxQgLoOKytYUAH/0ZDIy1Fx31VoZp5MHwGLlYH w2bvK74f68GwjgPwG1O4iyMHEooHUc9SBY8ub83fo2nTQ/Zsx5j3SgD0g2o82beq SC35OBCD6eTQvuXE88WvJ2kPWgdg/EYhtu4g7aILttoje0shFXXKxBN8hZ0i82ZO au0Z939g/qW36YZWHBTqWFZ8/5uxjzF0JMwj/VzS0/M/cRfr+7BiLvErQ8rIE5Ca JRoQcy0hIBmL1NNn5X6JIP8uaC5+4io7YExLflDL2Uh6wB1OmZkv/uC3iKwGPrgi oZJn6GYRLivveDyFmnMHaM2KzlaWLDjQMR97S/DwfADU7ylxwvivEXP5+9ciytc= =xcnT -----END PGP SIGNATURE----- --3AKgk7LDSLexxAuTxFUCxQQgOEHAFOLtv--