From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44827) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZhJtT-0000Gw-2W for qemu-devel@nongnu.org; Wed, 30 Sep 2015 12:06:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZhJtN-0000EE-Fo for qemu-devel@nongnu.org; Wed, 30 Sep 2015 12:06:10 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46326) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZhJtN-0000E6-9m for qemu-devel@nongnu.org; Wed, 30 Sep 2015 12:06:05 -0400 References: <1442872682-6523-1-git-send-email-eblake@redhat.com> <1442872682-6523-14-git-send-email-eblake@redhat.com> From: Eric Blake Message-ID: <560C086B.8000000@redhat.com> Date: Wed, 30 Sep 2015 10:06:03 -0600 MIME-Version: 1.0 In-Reply-To: <1442872682-6523-14-git-send-email-eblake@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="O11k8qrTA8hKqpjcuM3H9SOujq53L8jii" Subject: Re: [Qemu-devel] [PATCH v5 13/46] qapi: Track owner of each object member List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: marcandre.lureau@redhat.com, ehabkost@redhat.com, Michael Roth , armbru@redhat.com, DirtY.iCE.hu@gmail.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --O11k8qrTA8hKqpjcuM3H9SOujq53L8jii Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/21/2015 03:57 PM, Eric Blake wrote: >=20 > Where implicit types are involved, the code intentionally tries > to pick the name of the owner of that implicit type, rather than > the type name itself (a user reading the error message should be > able to grep for the problem in their original file, but will not > be able to locate a generated implicit name). For simple unions, > I chose not to pass the union name to the variants constructor; > but this should be okay because in practice nothing should ever > conflict with the implicit 'type' of a simple union. This last sentence is false; I later discovered that we can indeed have collisions with a branch named 'type' (see v6 subset A 6/16). So I'll probably have to adjust this a bit. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --O11k8qrTA8hKqpjcuM3H9SOujq53L8jii Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWDAhrAAoJEKeha0olJ0Nq0zgH/2wteAT/jHyG31zx6p5lxCUt aTSp1yA11FFqpFn8DKbFNtkpcm1rRMJ5AMibh4gFfuhemlom0Yq1LD3lGcXNSgGm 4ayXpzpferVDIQFjp1OVVpqnTrPCIlb1r0wKZ4hg4Pb4TbXXFO7sIEUGwyZVqT1x d0NwaPUuVaOXO0a1QfZa0DuDM1cBRWm/HkDTFqu5Ysr0wYF5WhGuWE8/wHKQ4esd ryhSyW8q4zdsWnd5nkYZJ1b/TmbBxuVuMLSPDeYdgSA9rdSAYovBUpRsEsIfi309 02khXGpiZP9hOiYRrUoVpxYMwPm4Wxeg//y8bFuQpDjZVxXpRqhLiaAKwhhemQ0= =NTBd -----END PGP SIGNATURE----- --O11k8qrTA8hKqpjcuM3H9SOujq53L8jii--