From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57468) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZhMYA-0005wH-L7 for qemu-devel@nongnu.org; Wed, 30 Sep 2015 14:56:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZhMY5-0006jj-L1 for qemu-devel@nongnu.org; Wed, 30 Sep 2015 14:56:22 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50241) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZhMY5-0006jd-EY for qemu-devel@nongnu.org; Wed, 30 Sep 2015 14:56:17 -0400 References: <1442889976-8733-1-git-send-email-famz@redhat.com> <1442889976-8733-14-git-send-email-famz@redhat.com> From: John Snow Message-ID: <560C304E.1030401@redhat.com> Date: Wed, 30 Sep 2015 14:56:14 -0400 MIME-Version: 1.0 In-Reply-To: <1442889976-8733-14-git-send-email-famz@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v7 13/14] qmp-commands.hx: Update the supported 'transaction' operations List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng , qemu-devel@nongnu.org Cc: Kevin Wolf , Jeff Cody , Max Reitz , vsementsov@parallels.com, stefanha@redhat.com On 09/21/2015 10:46 PM, Fam Zheng wrote: > From: Kashyap Chamarthy > > Although the canonical source of reference for QMP commands is > qapi-schema.json, for consistency's sake, update qmp-commands.hx to > state the list of supported transactionable operations, namely: > > drive-backup > blockdev-backup > blockdev-snapshot-internal-sync > abort > block-dirty-bitmap-add > block-dirty-bitmap-clear > > Signed-off-by: Kashyap Chamarthy > Reviewed-by: Eric Blake > Reviewed-by: Max Reitz > Signed-off-by: John Snow > Signed-off-by: Stefan Hajnoczi > Signed-off-by: Fam Zheng > --- > qmp-commands.hx | 21 ++++++++++++++++----- > 1 file changed, 16 insertions(+), 5 deletions(-) > > diff --git a/qmp-commands.hx b/qmp-commands.hx > index 66f0300..365c874 100644 > --- a/qmp-commands.hx > +++ b/qmp-commands.hx > @@ -1265,11 +1265,22 @@ SQMP > transaction > ----------- > > -Atomically operate on one or more block devices. The only supported operations > -for now are drive-backup, internal and external snapshotting. A list of > -dictionaries is accepted, that contains the actions to be performed. > -If there is any failure performing any of the operations, all operations > -for the group are abandoned. > +Atomically operate on one or more block devices. Operations that are > +currently supported: > + > + - drive-backup > + - blockdev-backup > + - blockdev-snapshot-sync > + - blockdev-snapshot-internal-sync > + - abort > + - block-dirty-bitmap-add > + - block-dirty-bitmap-clear > + > +Refer to the qemu/qapi-schema.json file for minimum required QEMU > +versions for these operations. A list of dictionaries is accepted, > +that contains the actions to be performed. If there is any failure > +performing any of the operations, all operations for the group are > +abandoned. > > For external snapshots, the dictionary contains the device, the file to use for > the new snapshot, and the format. The default format, if not specified, is > It recently occurred to me that this patch is incomplete, see just below: 'Arguments: actions array: - "type": the operation to perform. The only supported value is "blockdev-snapshot-sync". (json-string) ' That's not the only type, now -- all the others listed above are valid too, so this section could use a brush-up as well. --js