From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49116) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zhfz7-0005zw-H8 for qemu-devel@nongnu.org; Thu, 01 Oct 2015 11:41:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zhfz4-0002DI-Ak for qemu-devel@nongnu.org; Thu, 01 Oct 2015 11:41:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44790) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zhfz4-0002DC-5g for qemu-devel@nongnu.org; Thu, 01 Oct 2015 11:41:26 -0400 References: <1443565276-4535-1-git-send-email-eblake@redhat.com> <1443565276-4535-6-git-send-email-eblake@redhat.com> <87twqa24e5.fsf@blackfin.pond.sub.org> <560D30C9.1000209@redhat.com> <87lhbmtxet.fsf@blackfin.pond.sub.org> From: Eric Blake Message-ID: <560D541E.2060602@redhat.com> Date: Thu, 1 Oct 2015 09:41:18 -0600 MIME-Version: 1.0 In-Reply-To: <87lhbmtxet.fsf@blackfin.pond.sub.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="5Hh1EVKMQuTaSJFpieWbFcKKfKuKIx7f1" Subject: Re: [Qemu-devel] [PATCH v7 05/18] qapi: Test for various name collisions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: marcandre.lureau@redhat.com, qemu-devel@nongnu.org, ehabkost@redhat.com, Michael Roth This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --5Hh1EVKMQuTaSJFpieWbFcKKfKuKIx7f1 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10/01/2015 09:34 AM, Markus Armbruster wrote: >>> Do we have a test for the simpler case of a struct inheriting from >>> itself? >> >> Not here, but in v5 16/46. That's because it asserts, but while it was= >> easy to fix up in the QAPISchema.check(), I did not find it worth the >> churn to fix it up in the ad hoc parse code just to rip it back out >> later, and the QAPISchema.check() code requires several scaffolding >> patches (so it wasn't as easy as fixing the union 'type' clash asserts= ). >> Tracking an assertion failure for any more than one patch at a time i= s >> horrible (as any other change to qapi.py changes line numbers that >> affect the assertion failure). >=20 > Well, I'm happy to take a test for inheritance loops, or leave it > uncovered for now, but I don't want to take a non-working test of an > unimplemented obscure case "union" without a test for the implemented > case "struct". >=20 > I can: >=20 > A. Drop this test case. >=20 > B. Replace it with the test case from 16/46. >=20 > C. Add the test case from 16/46 and keep this one. >=20 > I very much prefer B. You? If we go with B, we'd have an assertion failure that does not get fixed by 6/18, and therefore is subject to churn until the fix is present. I'm leaning towards A (calling self-inheritance a name collision is a bit of a stretch in the first place; and leaving it untested until 16/46 goes in doesn't hurt). --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --5Hh1EVKMQuTaSJFpieWbFcKKfKuKIx7f1 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWDVQeAAoJEKeha0olJ0NqWvIH/AkDEdZfaalEoWgxPJ1n+lRb GOtZfBHMPoV/d5uoU9Ph+ezAw16zjZOjJ5vAn7QjGbKZUw57UCp/be21Ldq7EyPT 59K0IerFxxSj/+8ZoBOAB3G7884vOVWrN6SXZ6NsJvSH0SXd9VVhln4h7Ny6lCWd XZ23ao/7bEh4sKjvMT3ORAALr8oUfOiP/2BW9nA7NyebYSVuRCUm1kKEZ+zbLOpU LPVsq4/TUIX3IWaUcyTX67I2JdWbKYoaqGTpJeu/M9xasQ/8zTMfza43LEPO82SA h1eOW3vgmc+EC+0Mu/8NmNwZeXKwrZEwQWYMgHlqveJcnbreetI5LkRDiiQTCKE= =3Izc -----END PGP SIGNATURE----- --5Hh1EVKMQuTaSJFpieWbFcKKfKuKIx7f1--