From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48924)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1ZhiAq-000133-AV
	for qemu-devel@nongnu.org; Thu, 01 Oct 2015 14:01:47 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1ZhiAm-0004fc-DX
	for qemu-devel@nongnu.org; Thu, 01 Oct 2015 14:01:44 -0400
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
References: <1443717273-5280-1-git-send-email-jsnow@redhat.com>
	<1443717273-5280-4-git-send-email-jsnow@redhat.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <560D7500.1000705@redhat.com>
Date: Thu, 1 Oct 2015 20:01:36 +0200
MIME-Version: 1.0
In-Reply-To: <1443717273-5280-4-git-send-email-jsnow@redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 3/3] block: prohibit migration during
	transactions
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: John Snow <jsnow@redhat.com>, qemu-block@nongnu.org
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com



On 01/10/2015 18:34, John Snow wrote:
> +
> +    error_setg(&blocker, "Block device(s) are in use by a Block Transaction");

s/Block Transaction/transaction command/

But how can migration start during a transaction?

> +    ret = migrate_add_blocker(blocker, errp);
> +    if (ret < 0) {
> +        goto cleanup_mig;
> +    }
>  
>      QSIMPLEQ_HEAD(snap_bdrv_states, BlkTransactionState) snap_bdrv_states;
>      QSIMPLEQ_INIT(&snap_bdrv_states);
> @@ -1814,6 +1823,9 @@ exit:
>          }
>          g_free(state);
>      }
> + cleanup_mig:
> +    migrate_del_blocker(blocker);
> +    error_free(blocker);