From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42379) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZhixY-0002We-V6 for qemu-devel@nongnu.org; Thu, 01 Oct 2015 14:52:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZhixT-0000wk-A2 for qemu-devel@nongnu.org; Thu, 01 Oct 2015 14:52:04 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33370) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZhixT-0000wg-5Y for qemu-devel@nongnu.org; Thu, 01 Oct 2015 14:51:59 -0400 References: <1443565276-4535-1-git-send-email-eblake@redhat.com> <1443565276-4535-6-git-send-email-eblake@redhat.com> <87twqa24e5.fsf@blackfin.pond.sub.org> <560D30C9.1000209@redhat.com> <87lhbmtxet.fsf@blackfin.pond.sub.org> <560D541E.2060602@redhat.com> <87oagimqth.fsf@blackfin.pond.sub.org> From: Eric Blake Message-ID: <560D80C9.3030708@redhat.com> Date: Thu, 1 Oct 2015 12:51:53 -0600 MIME-Version: 1.0 In-Reply-To: <87oagimqth.fsf@blackfin.pond.sub.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="kwU5WPaoQGtQi2Xgg2AAwc1aHm3X2QUNi" Subject: Re: [Qemu-devel] [PATCH v7 05/18] qapi: Test for various name collisions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: Michael Roth , marcandre.lureau@redhat.com, qemu-devel@nongnu.org, ehabkost@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --kwU5WPaoQGtQi2Xgg2AAwc1aHm3X2QUNi Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10/01/2015 11:39 AM, Markus Armbruster wrote: >> I'm leaning towards A (calling self-inheritance a name collision is a >> bit of a stretch in the first place; and leaving it untested until 16/= 46 >> goes in doesn't hurt). >=20 > Okay, A. it is. I pushed to branch qapi-next at > http://repo.or.cz/qemu/armbru.git Branch looks good to go with one nit: 15/18 commit message (currently e7462ff) has a typo in the text you massaged: The generated code has fewer blank line in qapi-event.c functions, but has no semantic difference. s/line/lines/ I'll rebase my remaining patches on top of your tip, and let you decide how long to wait before sending the pull request. And with your rewrite of 17/18, this part of the series no longer depends on the python 2.6 configure patch. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --kwU5WPaoQGtQi2Xgg2AAwc1aHm3X2QUNi Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWDYDJAAoJEKeha0olJ0NqBh8H/iFlP7XBPusJFQs4knaVRVqd y4Yl47FIn+tsoWHSDglq+9ob/JvbJyX7nWS5gF0Z3sG2qlZWPYvdltQor6/xeh9h HS7ohDLHf/762vOjMaSEwruImwZzpQ6oh7Llnh4JRO20BH21hKnHVL/X+48y4wpf DBNcUZ1A5z3ktU0/QUzjZiLgsGIUkE7T0onefKoVlcGgsHrk+LEgzblkQ8lqs+Eq G4c2wxbUKEKmdYBLm8+SuOM45a+5rf3cwbM1W1faalXNmLLY+AOh3OxfYw+OEwIW faaz3WDomA0kY/oXjK6okpduZcSTJwQk/SvdYDGZsn43oOOpHaBNw8wis0d00r4= =kQ2L -----END PGP SIGNATURE----- --kwU5WPaoQGtQi2Xgg2AAwc1aHm3X2QUNi--