From: Eric Blake <eblake@redhat.com>
To: Kashyap Chamarthy <kchamart@redhat.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, jsnow@redhat.com, famz@redhat.com, mreitz@redhat.com
Subject: Re: [Qemu-devel] [PATCH] qmp-commands.hx: Update the supported 'transaction' operations
Date: Fri, 2 Oct 2015 06:40:28 -0600 [thread overview]
Message-ID: <560E7B3C.2080905@redhat.com> (raw)
In-Reply-To: <1443787955-19823-1-git-send-email-kchamart@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 876 bytes --]
On 10/02/2015 06:12 AM, Kashyap Chamarthy wrote:
> Although the canonical source of reference for QMP commands is
> qapi-schema.json, for consistency's sake, update qmp-commands.hx to
> state the list of supported transactionable operations, namely:
>
> drive-backup
> blockdev-backup
> blockdev-snapshot-internal-sync
> abort
> block-dirty-bitmap-add
> block-dirty-bitmap-clear
>
> Also update the possible values for the "type" action array.
>
> Signed-off-by: Kashyap Chamarthy <kchamart@redhat.com>
> Reviewed-by: Eric Blake <eblake@redhat.com>
Significant enough changes that I would have dropped R-b before posting
to ensure it gets looked at. But fortunately, you did a good job, so you
can still keep my R-b.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2015-10-02 12:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-02 12:12 [Qemu-devel] [PATCH] qmp-commands.hx: Update the supported 'transaction' operations Kashyap Chamarthy
2015-10-02 12:40 ` Eric Blake [this message]
2015-10-02 12:51 ` Kashyap Chamarthy
2015-10-02 17:59 ` Max Reitz
2015-10-12 11:04 ` Kashyap Chamarthy
2015-10-12 13:54 ` Eric Blake
2015-10-12 15:31 ` John Snow
2015-10-12 11:30 ` Kevin Wolf
2015-11-23 18:58 ` Marc-André Lureau
2015-11-23 18:59 ` Marc-André Lureau
2015-11-23 19:02 ` John Snow
-- strict thread matches above, loose matches on Subject: below --
2015-04-23 12:46 Kashyap Chamarthy
2015-04-23 23:07 ` Eric Blake
2015-04-24 7:48 ` Kashyap Chamarthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=560E7B3C.2080905@redhat.com \
--to=eblake@redhat.com \
--cc=famz@redhat.com \
--cc=jsnow@redhat.com \
--cc=kchamart@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).