From: Thomas Huth <thuth@redhat.com>
To: Greg Kurz <gkurz@linux.vnet.ibm.com>
Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] ppc: drop useless register sync
Date: Fri, 2 Oct 2015 16:03:56 +0200 [thread overview]
Message-ID: <560E8ECC.8090301@redhat.com> (raw)
In-Reply-To: <20151001165621.5343.99690.stgit@bahia.lab.toulouse-stg.fr.ibm.com>
On 01/10/15 18:56, Greg Kurz wrote:
> Since msr is always synced, no need to read it from KVM.
Out of curiosity: Where does that happen?
Thanks,
Thomas
> Signed-off-by: Greg Kurz <gkurz@linux.vnet.ibm.com>
> ---
> target-ppc/translate_init.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c
> index b54147350d88..49611e8e41fe 100644
> --- a/target-ppc/translate_init.c
> +++ b/target-ppc/translate_init.c
> @@ -9624,8 +9624,6 @@ static bool ppc_cpu_is_big_endian(CPUState *cs)
> PowerPCCPU *cpu = POWERPC_CPU(cs);
> CPUPPCState *env = &cpu->env;
>
> - cpu_synchronize_state(cs);
> -
> return !msr_le;
> }
> #endif
>
>
next prev parent reply other threads:[~2015-10-02 14:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-01 16:56 [Qemu-devel] [PATCH] ppc: drop useless register sync Greg Kurz
2015-10-02 14:03 ` Thomas Huth [this message]
2015-10-02 15:37 ` Greg Kurz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=560E8ECC.8090301@redhat.com \
--to=thuth@redhat.com \
--cc=gkurz@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).