From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33046)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <thuth@redhat.com>) id 1Zi0wP-0003dE-4j
	for qemu-devel@nongnu.org; Fri, 02 Oct 2015 10:04:10 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <thuth@redhat.com>) id 1Zi0wK-0001Ae-63
	for qemu-devel@nongnu.org; Fri, 02 Oct 2015 10:04:05 -0400
References: <20151001165621.5343.99690.stgit@bahia.lab.toulouse-stg.fr.ibm.com>
From: Thomas Huth <thuth@redhat.com>
Message-ID: <560E8ECC.8090301@redhat.com>
Date: Fri, 2 Oct 2015 16:03:56 +0200
MIME-Version: 1.0
In-Reply-To: <20151001165621.5343.99690.stgit@bahia.lab.toulouse-stg.fr.ibm.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] ppc: drop useless register sync
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Greg Kurz <gkurz@linux.vnet.ibm.com>
Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org

On 01/10/15 18:56, Greg Kurz wrote:
> Since msr is always synced, no need to read it from KVM.

Out of curiosity: Where does that happen?

Thanks,
 Thomas


> Signed-off-by: Greg Kurz <gkurz@linux.vnet.ibm.com>
> ---
>  target-ppc/translate_init.c |    2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c
> index b54147350d88..49611e8e41fe 100644
> --- a/target-ppc/translate_init.c
> +++ b/target-ppc/translate_init.c
> @@ -9624,8 +9624,6 @@ static bool ppc_cpu_is_big_endian(CPUState *cs)
>      PowerPCCPU *cpu = POWERPC_CPU(cs);
>      CPUPPCState *env = &cpu->env;
>  
> -    cpu_synchronize_state(cs);
> -
>      return !msr_le;
>  }
>  #endif
> 
>