* [Qemu-devel] [PATCH] ppc: drop useless register sync
@ 2015-10-01 16:56 Greg Kurz
2015-10-02 14:03 ` Thomas Huth
0 siblings, 1 reply; 3+ messages in thread
From: Greg Kurz @ 2015-10-01 16:56 UTC (permalink / raw)
To: Alexander Graf; +Cc: qemu-ppc, qemu-devel
Since msr is always synced, no need to read it from KVM.
Signed-off-by: Greg Kurz <gkurz@linux.vnet.ibm.com>
---
target-ppc/translate_init.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c
index b54147350d88..49611e8e41fe 100644
--- a/target-ppc/translate_init.c
+++ b/target-ppc/translate_init.c
@@ -9624,8 +9624,6 @@ static bool ppc_cpu_is_big_endian(CPUState *cs)
PowerPCCPU *cpu = POWERPC_CPU(cs);
CPUPPCState *env = &cpu->env;
- cpu_synchronize_state(cs);
-
return !msr_le;
}
#endif
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] ppc: drop useless register sync
2015-10-01 16:56 [Qemu-devel] [PATCH] ppc: drop useless register sync Greg Kurz
@ 2015-10-02 14:03 ` Thomas Huth
2015-10-02 15:37 ` Greg Kurz
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Huth @ 2015-10-02 14:03 UTC (permalink / raw)
To: Greg Kurz; +Cc: qemu-ppc, qemu-devel
On 01/10/15 18:56, Greg Kurz wrote:
> Since msr is always synced, no need to read it from KVM.
Out of curiosity: Where does that happen?
Thanks,
Thomas
> Signed-off-by: Greg Kurz <gkurz@linux.vnet.ibm.com>
> ---
> target-ppc/translate_init.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c
> index b54147350d88..49611e8e41fe 100644
> --- a/target-ppc/translate_init.c
> +++ b/target-ppc/translate_init.c
> @@ -9624,8 +9624,6 @@ static bool ppc_cpu_is_big_endian(CPUState *cs)
> PowerPCCPU *cpu = POWERPC_CPU(cs);
> CPUPPCState *env = &cpu->env;
>
> - cpu_synchronize_state(cs);
> -
> return !msr_le;
> }
> #endif
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] ppc: drop useless register sync
2015-10-02 14:03 ` Thomas Huth
@ 2015-10-02 15:37 ` Greg Kurz
0 siblings, 0 replies; 3+ messages in thread
From: Greg Kurz @ 2015-10-02 15:37 UTC (permalink / raw)
To: Thomas Huth; +Cc: qemu-ppc, qemu-devel
On Fri, 2 Oct 2015 16:03:56 +0200
Thomas Huth <thuth@redhat.com> wrote:
> On 01/10/15 18:56, Greg Kurz wrote:
> > Since msr is always synced, no need to read it from KVM.
>
> Out of curiosity: Where does that happen?
>
It does not happen in fact... and this patch indeed breaks LE guests...
Not really sure how I got there... just forget it ! :)
Cheers.
--
Greg
> Thanks,
> Thomas
>
>
> > Signed-off-by: Greg Kurz <gkurz@linux.vnet.ibm.com>
> > ---
> > target-ppc/translate_init.c | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c
> > index b54147350d88..49611e8e41fe 100644
> > --- a/target-ppc/translate_init.c
> > +++ b/target-ppc/translate_init.c
> > @@ -9624,8 +9624,6 @@ static bool ppc_cpu_is_big_endian(CPUState *cs)
> > PowerPCCPU *cpu = POWERPC_CPU(cs);
> > CPUPPCState *env = &cpu->env;
> >
> > - cpu_synchronize_state(cs);
> > -
> > return !msr_le;
> > }
> > #endif
> >
> >
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-10-02 15:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-01 16:56 [Qemu-devel] [PATCH] ppc: drop useless register sync Greg Kurz
2015-10-02 14:03 ` Thomas Huth
2015-10-02 15:37 ` Greg Kurz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).