From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57206) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zi3NE-0006bE-4p for qemu-devel@nongnu.org; Fri, 02 Oct 2015 12:40:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zi3ND-0007OC-29 for qemu-devel@nongnu.org; Fri, 02 Oct 2015 12:39:56 -0400 References: <1443461938-30039-1-git-send-email-jsnow@redhat.com> <20151002105519.GB4373@noname.redhat.com> From: John Snow Message-ID: <560EB34F.3020208@redhat.com> Date: Fri, 2 Oct 2015 12:39:43 -0400 MIME-Version: 1.0 In-Reply-To: <20151002105519.GB4373@noname.redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Qemu-block] [PATCH] qtest/ide-test: ppc64be correction for ATAPI tests List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org, qemu-block@nongnu.org On 10/02/2015 06:55 AM, Kevin Wolf wrote: > Am 28.09.2015 um 19:38 hat John Snow geschrieben: >> the 16bit ide data register is LE by definition. >> >> Signed-off-by: John Snow >> --- >> tests/ide-test.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/tests/ide-test.c b/tests/ide-test.c >> index 5594738..b6e9e1a 100644 >> --- a/tests/ide-test.c >> +++ b/tests/ide-test.c >> @@ -633,7 +633,7 @@ static void send_scsi_cdb_read10(uint64_t lba, int nblocks) >> >> /* Send Packet */ >> for (i = 0; i < sizeof(Read10CDB)/2; i++) { >> - outw(IDE_BASE + reg_data, ((uint16_t *)&pkt)[i]); >> + outw(IDE_BASE + reg_data, cpu_to_le16(((uint16_t *)&pkt)[i])); >> } >> } >> >> @@ -733,7 +733,7 @@ static void cdrom_pio_impl(int nblocks) >> size_t offset = i * (limit / 2); >> size_t rem = (rxsize / 2) - offset; >> for (j = 0; j < MIN((limit / 2), rem); j++) { >> - rx[offset + j] = inw(IDE_BASE + reg_data); >> + rx[offset + j] = le16_to_cpu(inw(IDE_BASE + reg_data)); >> } >> ide_wait_intr(IDE_PRIMARY_IRQ); >> } > > Why doesn't the access in test_identify() need a fix? > > Kevin > The strings are stored as BE16 chunks but transmitted via an LE16 register, so if we want to decode the original string, we can apply *either* an LE16 or a BE16 swap to obtain the byte-ordered string. Yes, that took me a minute to figure out. We *could* apply a le16_to_cpu filter to re-obtain the raw original data, but then we'd just have to run it back through be16_to_cpu to get the string out anyway. In this test, we just cheat and run be16_to_cpu, which works. --js