Re: [Qemu-devel] [PATCH v2 14/16] blockjob: Store device name at job creation

[Max Reitz <mreitz@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 990 bytes --]

On 01.10.2015 15:13, Kevin Wolf wrote:
> Some block jobs change the block device graph on completion. This means
> that the device that owns the job and originally was addressed with its
> device name may no longer be what the corresponding BlockBackend points
> to.
> 
> Previously, the effects of bdrv_swap() ensured that the job was (at
> least partially) transferred to the target image. Events that contain
> the device name could still use bdrv_get_device_name(job->bs) and get
> the same result.
> 
> After removing bdrv_swap(), this won't work any more. Instead, save the
> device name at job creation and use that copy for QMP events and
> anything else identifying the job.
> 
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
>  block/mirror.c           |  3 +--
>  blockjob.c               | 15 ++++++++-------
>  include/block/blockjob.h |  8 ++++++++
>  3 files changed, 17 insertions(+), 9 deletions(-)

Reviewed-by: Max Reitz <mreitz@redhat.com>


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]