From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60649) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zi4Nj-0001cv-7H for qemu-devel@nongnu.org; Fri, 02 Oct 2015 13:44:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zi4Ni-0001ws-Gw for qemu-devel@nongnu.org; Fri, 02 Oct 2015 13:44:31 -0400 References: <1443705214-9304-1-git-send-email-kwolf@redhat.com> <1443705214-9304-15-git-send-email-kwolf@redhat.com> From: Max Reitz Message-ID: <560EC273.4000604@redhat.com> Date: Fri, 2 Oct 2015 19:44:19 +0200 MIME-Version: 1.0 In-Reply-To: <1443705214-9304-15-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="RGmjwg7EpE1O6SeGv4KK1wafi3dEtLiDi" Subject: Re: [Qemu-devel] [PATCH v2 14/16] blockjob: Store device name at job creation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-block@nongnu.org Cc: jcody@redhat.com, berto@igalia.com, armbru@redhat.com, stefanha@redhat.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --RGmjwg7EpE1O6SeGv4KK1wafi3dEtLiDi Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable On 01.10.2015 15:13, Kevin Wolf wrote: > Some block jobs change the block device graph on completion. This means= > that the device that owns the job and originally was addressed with its= > device name may no longer be what the corresponding BlockBackend points= > to. >=20 > Previously, the effects of bdrv_swap() ensured that the job was (at > least partially) transferred to the target image. Events that contain > the device name could still use bdrv_get_device_name(job->bs) and get > the same result. >=20 > After removing bdrv_swap(), this won't work any more. Instead, save the= > device name at job creation and use that copy for QMP events and > anything else identifying the job. >=20 > Signed-off-by: Kevin Wolf > --- > block/mirror.c | 3 +-- > blockjob.c | 15 ++++++++------- > include/block/blockjob.h | 8 ++++++++ > 3 files changed, 17 insertions(+), 9 deletions(-) Reviewed-by: Max Reitz --RGmjwg7EpE1O6SeGv4KK1wafi3dEtLiDi Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWDsJzAAoJEDuxQgLoOKyty5wH/2iodHvfOPjBIiZSZi7zu87w 6lMDmH62VcUSm0l67VYa79xLjObOJdni1wwuBgpWUxMRs+TsGIPu25r/gazfnd+z DSq1XjqQb1r4Vf2jDuw43shK0j912iD7rc6nvXg5h66ZCiqzBAAVayFT3tT/JefN NwaTqDSq84IyZnXVLa3Ba69SOcKmEXDWa3EJB2v428sELYuEcSyODTY912ftirGk kNLR6f2hmLqlkBC05htPkYqkFnJJn/SeO4atd3KL7g0QFFPGMSK2EfVxeYnmjFeJ TxKoY4emV8jUDcW34PWrc1McwJXR+ud/on64DH/B1S0eVkrI+vULwyEFxcYRVlg= =isrT -----END PGP SIGNATURE----- --RGmjwg7EpE1O6SeGv4KK1wafi3dEtLiDi--