From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36857) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZiR2i-0004y5-AV for qemu-devel@nongnu.org; Sat, 03 Oct 2015 13:56:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZiR2f-0007QQ-1w for qemu-devel@nongnu.org; Sat, 03 Oct 2015 13:56:20 -0400 Received: from resqmta-po-09v.sys.comcast.net ([96.114.154.168]:41653) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZiR2e-0007QH-T7 for qemu-devel@nongnu.org; Sat, 03 Oct 2015 13:56:16 -0400 References: <1443760312-656-1-git-send-email-eblake@redhat.com> <1443760312-656-11-git-send-email-eblake@redhat.com> From: Eric Blake Message-ID: <561016BD.9020202@redhat.com> Date: Sat, 3 Oct 2015 11:56:13 -0600 MIME-Version: 1.0 In-Reply-To: <1443760312-656-11-git-send-email-eblake@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="bbRek8CfTqhfJ91JNKj0P3bJTLqCF6G9I" Subject: Re: [Qemu-devel] [PATCH v6 10/12] qapi: Correct error for union branch 'kind' clash List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: marcandre.lureau@redhat.com, Michael Roth , ehabkost@redhat.com, armbru@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --bbRek8CfTqhfJ91JNKj0P3bJTLqCF6G9I Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10/01/2015 10:31 PM, Eric Blake wrote: > The error message when a simple union or alternate contains a > branch named 'kind' is ugly, because it is tied to the Schema > member named 'type'. A future patch will fix the generated C > to match QMP, but until that point, we can hack things with > a temporary subclass to make the error message reflect the > actually collision. I found a cleaner way to do this, and will be dropping this patch, except for the testsuite improvements which I will be merging into 9/12. >=20 > Rename alternate-clash to alternate-clash-members, and add a > new test alternate-clash-type. While similar to the earlier > addition of union-clash-type, we have one major difference: a > future patch will be simplifying alternates to not need an > implict AlternateKind enum, but we still need to detect the > collision with the resulting C 'qtype_code type;' tag. >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --bbRek8CfTqhfJ91JNKj0P3bJTLqCF6G9I Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWEBa+AAoJEKeha0olJ0Nq1OEH/i3/6K76JUVyga1D3NEIUWEw VsByiK6ie9Er+HlHL+Vgd4kYrgWfrj5elh6ZfsjJgFmLHvCFHW3bNN8fuZHoLaIW BWi2XaNpq4nMJDk7tPGKkwi3TDJEfdreAa1k6JP15AUvDaOzA8Giy0GRGS1ZWjOP JPRnyd63A8teJBbDVsGy0WUHXShmomd/HRo0TZ3qn4+XDrb2Fe+ZTRgzAO6zzX++ PXYt6CoICi47izmMKQG0xbRLjOXiM4jOWNCXQ4hyc7FyiRWc+W5Dw+kzMVQ/7mbM W0gKvxvuQ84Ib0pn9KZAzCEtQ56Vz06QOznJs2pLkzId5/8y/3KKYTXCHpuK7AI= =EmCw -----END PGP SIGNATURE----- --bbRek8CfTqhfJ91JNKj0P3bJTLqCF6G9I--