From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53797) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zj4C1-0003Gp-Kt for qemu-devel@nongnu.org; Mon, 05 Oct 2015 07:44:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zj4Bx-0005XU-KI for qemu-devel@nongnu.org; Mon, 05 Oct 2015 07:44:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59971) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zj4Bx-0005WO-Ep for qemu-devel@nongnu.org; Mon, 05 Oct 2015 07:44:29 -0400 References: <1443812991-17356-1-git-send-email-marcandre.lureau@redhat.com> <1443812991-17356-41-git-send-email-marcandre.lureau@redhat.com> <5612575E.2090604@huawei.com> From: Paolo Bonzini Message-ID: <56126298.8010309@redhat.com> Date: Mon, 5 Oct 2015 13:44:24 +0200 MIME-Version: 1.0 In-Reply-To: <5612575E.2090604@huawei.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v5 40/48] glib-compat: add 2.38/2.40/2.46 asserts List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Claudio Fontana , marcandre.lureau@redhat.com, qemu-devel@nongnu.org Cc: drjones@redhat.com, cam@cs.ualberta.ca, stefanha@redhat.com On 05/10/2015 12:56, Claudio Fontana wrote: > Hi, I did not find g_assertion_message in any of the exported GLIB APIs. > In fact, I found it in glib/gtestutils.h under the section "internal ABI". > This is a hint that we should not be using it right? Since this only matters for these pre-2.46 versions, where we know that g_assertion_message exists, we can use it. Paolo