From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54486) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zj4GU-0004jX-Ev for qemu-devel@nongnu.org; Mon, 05 Oct 2015 07:49:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zj4GR-0008HY-7E for qemu-devel@nongnu.org; Mon, 05 Oct 2015 07:49:10 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43407) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zj4GR-0008HT-16 for qemu-devel@nongnu.org; Mon, 05 Oct 2015 07:49:07 -0400 References: <1443914889-9619-1-git-send-email-somlo@cmu.edu> <20151005100035.GA19064@leverpostej> From: Paolo Bonzini Message-ID: <561263A4.2020304@redhat.com> Date: Mon, 5 Oct 2015 13:48:52 +0200 MIME-Version: 1.0 In-Reply-To: <20151005100035.GA19064@leverpostej> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 0/4] SysFS driver for QEMU fw_cfg device List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Mark Rutland , "Gabriel L. Somlo" Cc: peter.maydell@linaro.org, paul@pwsan.com, matt.fleming@intel.com, catalin.marinas@arm.com, jordan.l.justen@intel.com, kernelnewbies@kernelnewbies.org, gregkh@linuxfoundation.org, zajec5@gmail.com, will.deacon@arm.com, linux-kernel@vger.kernel.org, leif.lindholm@linaro.org, qemu-devel@nongnu.org, ard.biesheuvel@linaro.org, galak@codeaurora.org, mst@redhat.com, hanjun.guo@linaro.org, agross@codeaurora.org, linux-api@vger.kernel.org, lersek@redhat.com, kraxel@redhat.com On 05/10/2015 12:00, Mark Rutland wrote: > Some of the keys in the example look like they'd come from other sources > (e.g. the *-tables entries), while others look like kernel/bootloader > configuration options (e.g. etc/boot-fail-wait, bootorder) -- I'm > concerned about redundancy here. The redundancy is because the firmware and the bootloader actually _consume_ these fw_cfg strings to produce the others (the ACPI tables, the kernel configuration options). On the other hand, hiding some strings just because they ought to have been consumed already makes little sense. Paolo