From: Paolo Bonzini <pbonzini@redhat.com>
To: Alexey Kardashevskiy <aik@ozlabs.ru>,
Laurent Vivier <lvivier@redhat.com>,
David Gibson <david@gibson.dropbear.id.au>
Cc: thuth@redhat.com, Michael Roth <mdroth@linux.vnet.ibm.com>,
Juan Quintela <quintela@redhat.com>,
gwshan@linux.vnet.ibm.com, qemu-devel@nongnu.org,
alex.williamson@redhat.com, qemu-ppc@nongnu.org
Subject: Re: [Qemu-devel] [RFC PATCH 07/10] spapr_pci: Allow PCI host bridge DMA window to be configured
Date: Mon, 5 Oct 2015 16:13:30 +0200 [thread overview]
Message-ID: <5612858A.80907@redhat.com> (raw)
In-Reply-To: <560F2069.5030902@ozlabs.ru>
On 03/10/2015 02:25, Alexey Kardashevskiy wrote:
>> I think this is the aim of VMSTATE_UINT64_EQUAL() ?
>
> We use it only for things which cannot be set via the command line
> and ideally there should be no VMSTATE_*_EQUAL. If something can be
> set via the command line, then the management software (read -
> libvirt) runs QEMU with explicit parameters to guarantee that these
> are equal.
VMSTATE_*_EQUAL is used when a value is later used as e.g. the size of
an array. It basically provides bounds checking for the subsequent
array, avoiding that an invalid migration file or an error issuing the
QEMU command on the destination transforms into a buffer overflow.
Michael Roth did most of this work, IIRC. Documenting it in
docs/migration.txt would be nice.
Paolo
next prev parent reply other threads:[~2015-10-05 14:13 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-17 13:09 [Qemu-devel] [RFC PATCH 00/10] pseries: Allow VFIO devices on spapr-pci-host-bridge David Gibson
2015-09-17 13:09 ` [Qemu-devel] [RFC PATCH 01/10] vfio: Remove unneeded union from VFIOContainer David Gibson
2015-09-18 6:15 ` Alexey Kardashevskiy
2015-09-23 10:31 ` Thomas Huth
2015-09-23 23:14 ` David Gibson
2015-09-23 13:18 ` Laurent Vivier
2015-09-17 13:09 ` [Qemu-devel] [RFC PATCH 02/10] vfio: Generalize vfio_listener_region_add failure path David Gibson
2015-09-23 9:13 ` Thomas Huth
2015-09-23 13:31 ` Laurent Vivier
2015-09-17 13:09 ` [Qemu-devel] [RFC PATCH 03/10] vfio: Check guest IOVA ranges against host IOMMU capabilities David Gibson
2015-09-18 6:38 ` Alexey Kardashevskiy
2015-09-23 10:10 ` Thomas Huth
2015-09-23 11:07 ` David Gibson
2015-09-23 23:43 ` David Gibson
2015-09-23 14:26 ` Laurent Vivier
2015-09-17 13:09 ` [Qemu-devel] [RFC PATCH 04/10] vfio: Record host IOMMU's available IO page sizes David Gibson
2015-09-23 10:29 ` Thomas Huth
2015-09-23 14:30 ` Laurent Vivier
2015-09-17 13:09 ` [Qemu-devel] [RFC PATCH 05/10] memory: Allow replay of IOMMU mapping notifications David Gibson
2015-09-23 10:40 ` Thomas Huth
2015-09-23 16:35 ` Laurent Vivier
2015-09-23 23:47 ` David Gibson
2015-09-23 17:04 ` Laurent Vivier
2015-09-23 23:50 ` David Gibson
2015-09-24 7:09 ` Laurent Vivier
2015-09-17 13:09 ` [Qemu-devel] [RFC PATCH 06/10] vfio: Allow hotplug of containers onto existing guest IOMMU mappings David Gibson
2015-09-17 16:54 ` Alex Williamson
2015-09-17 23:31 ` David Gibson
2015-09-23 11:02 ` Thomas Huth
2015-09-23 23:50 ` David Gibson
2015-09-23 18:44 ` Laurent Vivier
2015-09-17 13:09 ` [Qemu-devel] [RFC PATCH 07/10] spapr_pci: Allow PCI host bridge DMA window to be configured David Gibson
2015-09-23 11:08 ` Thomas Huth
2015-09-23 23:56 ` David Gibson
2015-09-23 18:55 ` Laurent Vivier
2015-09-23 23:54 ` David Gibson
2015-09-24 6:59 ` Laurent Vivier
2015-10-03 0:25 ` Alexey Kardashevskiy
2015-10-05 14:13 ` Paolo Bonzini [this message]
2015-10-06 3:25 ` David Gibson
2015-10-06 4:18 ` David Gibson
2015-09-17 13:09 ` [Qemu-devel] [RFC PATCH 08/10] spapr_iommu: Rename vfio_accel parameter David Gibson
2015-09-17 16:54 ` Alex Williamson
2015-09-17 23:34 ` David Gibson
2015-09-17 13:09 ` [Qemu-devel] [RFC PATCH 09/10] spapr_iommu: Provide a function to switch a TCE table to allowing VFIO David Gibson
2015-09-17 16:54 ` Alex Williamson
2015-09-23 11:24 ` Thomas Huth
2015-09-24 0:35 ` David Gibson
2015-09-17 13:09 ` [Qemu-devel] [RFC PATCH 10/10] spapr_pci: Allow VFIO devices to work on the normal PCI host bridge David Gibson
2015-09-17 16:54 ` [Qemu-devel] [RFC PATCH 00/10] pseries: Allow VFIO devices on spapr-pci-host-bridge Alex Williamson
2015-09-23 11:26 ` Thomas Huth
2015-09-23 16:46 ` Laurent Vivier
2015-09-24 1:02 ` David Gibson
2015-09-24 7:02 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5612858A.80907@redhat.com \
--to=pbonzini@redhat.com \
--cc=aik@ozlabs.ru \
--cc=alex.williamson@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=gwshan@linux.vnet.ibm.com \
--cc=lvivier@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=quintela@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).