From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41545)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Claudio.Fontana@huawei.com>) id 1Zj6xI-0001Uh-1V
	for qemu-devel@nongnu.org; Mon, 05 Oct 2015 10:41:32 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Claudio.Fontana@huawei.com>) id 1Zj6xE-0000xa-R4
	for qemu-devel@nongnu.org; Mon, 05 Oct 2015 10:41:31 -0400
Received: from lhrrgout.huawei.com ([194.213.3.17]:15103)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Claudio.Fontana@huawei.com>) id 1Zj6xE-0000xK-Im
	for qemu-devel@nongnu.org; Mon, 05 Oct 2015 10:41:28 -0400
References: <1443812991-17356-1-git-send-email-marcandre.lureau@redhat.com>
	<1443812991-17356-41-git-send-email-marcandre.lureau@redhat.com>
	<5612575E.2090604@huawei.com> <56126298.8010309@redhat.com>
	<CAJ+F1CKoMfEXQvT7dpdLOca3HyESjWtopSyi1N8ghEHfRwbLfg@mail.gmail.com>
From: Claudio Fontana <claudio.fontana@huawei.com>
Message-ID: <56128C0B.1010705@huawei.com>
Date: Mon, 5 Oct 2015 16:41:15 +0200
MIME-Version: 1.0
In-Reply-To: <CAJ+F1CKoMfEXQvT7dpdLOca3HyESjWtopSyi1N8ghEHfRwbLfg@mail.gmail.com>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH v5 40/48] glib-compat: add 2.38/2.40/2.46
 asserts
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= <marcandre.lureau@gmail.com>, Paolo
	Bonzini <pbonzini@redhat.com>
Cc: Andrew Jones <drjones@redhat.com>, cam <cam@cs.ualberta.ca>, QEMU <qemu-devel@nongnu.org>, Stefan Hajnoczi <stefanha@redhat.com>

On 05.10.2015 15:35, Marc-André Lureau wrote:
> glib comment is now fixed:
> 
> https://git.gnome.org/browse/glib/commit/?id=dabf6627886c1d21b9fe03c897809eb64ef2ac54
> 

Good!

> On Mon, Oct 5, 2015 at 1:44 PM, Paolo Bonzini <pbonzini@redhat.com> wrote:
>>
>>
>> On 05/10/2015 12:56, Claudio Fontana wrote:
>>> Hi, I did not find g_assertion_message in any of the exported GLIB APIs.
>>> In fact, I found it in glib/gtestutils.h under the section "internal ABI".
>>> This is a hint that we should not be using it right?
>>
>> Since this only matters for these pre-2.46 versions, where we know that
>> g_assertion_message exists, we can use it.
>>
>> Paolo


This is also a valid point.

Reviewed-by: Claudio Fontana <claudio.fontana@huawei.com>