From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>,
Markus Armbruster <armbru@redhat.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PULL 00/10] Fix device introspection regressions
Date: Mon, 5 Oct 2015 21:27:15 +0200 [thread overview]
Message-ID: <5612CF13.8020505@redhat.com> (raw)
In-Reply-To: <CAFEAcA9U5RLc84ug9k74WBmv1Amoh=ufzEX0rBDbO=X4Pu3G7A@mail.gmail.com>
On 05/10/2015 20:46, Peter Maydell wrote:
> The easy fix is to have some suitable ifdeffery in virtio-pci.c,
> similar to how we only register the virtio_9p_pci and virtio_scsi_pci
(vhost_scsi_pci)
> types if they've been configured into this build.
Hmm, actually there's no reason to limit
common-obj-$(CONFIG_VIRTIO) += virtio-input.o
common-obj-$(CONFIG_VIRTIO) += virtio-input-hid.o
to CONFIG_LINUX. Does it work to extract them out of the if (which is
only correct for virtio-input-host.o)?
That said, the ifdeffery _is_ needed for TYPE_VIRTIO_INPUT_HOST_PCI.
Paolo
next prev parent reply other threads:[~2015-10-05 19:27 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-02 17:20 [Qemu-devel] [PULL 00/10] Fix device introspection regressions Markus Armbruster
2015-10-02 17:20 ` [Qemu-devel] [PULL 01/10] memory: allow destroying a non-empty MemoryRegion Markus Armbruster
2015-10-02 17:20 ` [Qemu-devel] [PULL 02/10] hw: do not pass NULL to memory_region_init from instance_init Markus Armbruster
2015-10-02 17:20 ` [Qemu-devel] [PULL 03/10] macio: move DBDMA_init from instance_init to realize Markus Armbruster
2015-10-02 17:20 ` [Qemu-devel] [PULL 04/10] tests: Fix how qom-test is run Markus Armbruster
2015-10-02 17:20 ` [Qemu-devel] [PULL 05/10] libqtest: Clean up unused QTestState member sigact_old Markus Armbruster
2015-10-02 17:20 ` [Qemu-devel] [PULL 06/10] libqtest: New hmp() & friends Markus Armbruster
2015-10-02 17:20 ` [Qemu-devel] [PULL 07/10] device-introspect-test: New, covering device introspection Markus Armbruster
2015-10-02 17:20 ` [Qemu-devel] [PULL 08/10] qmp: Fix device-list-properties not to crash for abstract device Markus Armbruster
2015-10-02 17:20 ` [Qemu-devel] [PULL 09/10] qdev: Protect device-list-properties against broken devices Markus Armbruster
2015-10-02 17:20 ` [Qemu-devel] [PULL 10/10] Revert "qdev: Use qdev_get_device_class() for -device <type>, help" Markus Armbruster
2015-10-04 21:24 ` [Qemu-devel] [PULL 00/10] Fix device introspection regressions Peter Maydell
2015-10-05 6:49 ` Markus Armbruster
2015-10-05 11:55 ` Peter Maydell
2015-10-05 17:11 ` Markus Armbruster
2015-10-05 18:46 ` Peter Maydell
2015-10-05 19:27 ` Paolo Bonzini [this message]
2015-10-05 19:37 ` Peter Maydell
2015-10-06 5:46 ` Markus Armbruster
2015-10-06 8:05 ` Peter Maydell
2015-10-06 8:45 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5612CF13.8020505@redhat.com \
--to=pbonzini@redhat.com \
--cc=armbru@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).