From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33877) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZjBPr-0000cv-04 for qemu-devel@nongnu.org; Mon, 05 Oct 2015 15:27:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZjBPq-0002Hv-3v for qemu-devel@nongnu.org; Mon, 05 Oct 2015 15:27:18 -0400 Received: from mail-wi0-x234.google.com ([2a00:1450:400c:c05::234]:38773) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZjBPp-0002Hp-Ug for qemu-devel@nongnu.org; Mon, 05 Oct 2015 15:27:18 -0400 Received: by wiclk2 with SMTP id lk2so129282856wic.1 for ; Mon, 05 Oct 2015 12:27:17 -0700 (PDT) Sender: Paolo Bonzini References: <1443806441-23519-1-git-send-email-armbru@redhat.com> <87612l95e1.fsf@blackfin.pond.sub.org> <874mi55jgi.fsf@blackfin.pond.sub.org> From: Paolo Bonzini Message-ID: <5612CF13.8020505@redhat.com> Date: Mon, 5 Oct 2015 21:27:15 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PULL 00/10] Fix device introspection regressions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , Markus Armbruster Cc: QEMU Developers On 05/10/2015 20:46, Peter Maydell wrote: > The easy fix is to have some suitable ifdeffery in virtio-pci.c, > similar to how we only register the virtio_9p_pci and virtio_scsi_pci (vhost_scsi_pci) > types if they've been configured into this build. Hmm, actually there's no reason to limit common-obj-$(CONFIG_VIRTIO) += virtio-input.o common-obj-$(CONFIG_VIRTIO) += virtio-input-hid.o to CONFIG_LINUX. Does it work to extract them out of the if (which is only correct for virtio-input-host.o)? That said, the ifdeffery _is_ needed for TYPE_VIRTIO_INPUT_HOST_PCI. Paolo