From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60168) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZjEXY-0002Js-QZ for qemu-devel@nongnu.org; Mon, 05 Oct 2015 18:47:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZjEXV-0007ms-Ir for qemu-devel@nongnu.org; Mon, 05 Oct 2015 18:47:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44394) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZjEXV-0007mg-DK for qemu-devel@nongnu.org; Mon, 05 Oct 2015 18:47:25 -0400 References: <1441471439-6157-1-git-send-email-vsementsov@virtuozzo.com> <1441471439-6157-2-git-send-email-vsementsov@virtuozzo.com> From: John Snow Message-ID: <5612FDFB.5030003@redhat.com> Date: Mon, 5 Oct 2015 18:47:23 -0400 MIME-Version: 1.0 In-Reply-To: <1441471439-6157-2-git-send-email-vsementsov@virtuozzo.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 01/17] block: fix bdrv_dirty_bitmap_granularity() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladimir Sementsov-Ogievskiy , qemu-devel@nongnu.org Cc: kwolf@redhat.com, pbonzini@redhat.com, stefanha@redhat.com, den@openvz.org On 09/05/2015 12:43 PM, Vladimir Sementsov-Ogievskiy wrote: > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block.c | 2 +- > include/block/block.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/block.c b/block.c > index 4f7fc0d..6d14f5b 100644 > --- a/block.c > +++ b/block.c > @@ -3591,7 +3591,7 @@ uint32_t bdrv_get_default_bitmap_granularity(BlockDriverState *bs) > return granularity; > } > > -uint32_t bdrv_dirty_bitmap_granularity(BdrvDirtyBitmap *bitmap) > +uint32_t bdrv_dirty_bitmap_granularity(const BdrvDirtyBitmap *bitmap) > { > return BDRV_SECTOR_SIZE << hbitmap_granularity(bitmap->bitmap); > } > diff --git a/include/block/block.h b/include/block/block.h > index edc1510..fb7d410 100644 > --- a/include/block/block.h > +++ b/include/block/block.h > @@ -495,7 +495,7 @@ void bdrv_disable_dirty_bitmap(BdrvDirtyBitmap *bitmap); > void bdrv_enable_dirty_bitmap(BdrvDirtyBitmap *bitmap); > BlockDirtyInfoList *bdrv_query_dirty_bitmaps(BlockDriverState *bs); > uint32_t bdrv_get_default_bitmap_granularity(BlockDriverState *bs); > -uint32_t bdrv_dirty_bitmap_granularity(BdrvDirtyBitmap *bitmap); > +uint32_t bdrv_dirty_bitmap_granularity(const BdrvDirtyBitmap *bitmap); > bool bdrv_dirty_bitmap_enabled(BdrvDirtyBitmap *bitmap); > bool bdrv_dirty_bitmap_frozen(BdrvDirtyBitmap *bitmap); > DirtyBitmapStatus bdrv_dirty_bitmap_status(BdrvDirtyBitmap *bitmap); > As with Eric's review, with a commit message added: Reviewed-by: John Snow