From: Paolo Bonzini <pbonzini@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>, Houcheng Lin <houcheng@gmail.com>
Cc: peter.maydell@linaro.org, famz@redhat.com, kvm@vger.kernel.org,
linhaocheng@itri.org.tw, qemu-devel@nongnu.org,
alex.bennee@linaro.org
Subject: Re: [Qemu-devel] [RFC PATCH v4] os-android: Add support to android platform
Date: Tue, 6 Oct 2015 12:56:31 +0200 [thread overview]
Message-ID: <5613A8DF.3090801@redhat.com> (raw)
In-Reply-To: <20151006094713.GD19089@stefanha-thinkpad>
Just a couple comments since I reviewed the previous versions...
On 06/10/2015 11:47, Stefan Hajnoczi wrote:
> > #include <unistd.h>
> > -#include <sys/io.h>
> > #include <sys/mman.h>
> > #include <sys/types.h>
> > #include <sys/stat.h>
>
> What is the justification for this? Do you know why io.h was included
> before?
No reason, the same patch is en route through qemu-trivial.
>>
>> -
>> +#if defined(CONFIG_ANDROID)
>> + if (ptsname_r(mfd, slave, PATH_MAX) < 0)
>> + goto err;
>> +#else
>> if ((slave = ptsname(mfd)) == NULL)
>> goto err;
>> +#endif
>
> ptsname_r(3) should be used on all Linux hosts because it is reentrant.
> This improvement isn't Android-specific, please split it into a separate
> patch.
Actually everyone except Solaris and Android is already using openpty.
This is emulation code for those two OSes. (The gnulib manual mentions
that AIX 5.1, HP-UX 11, IRIX 6.5 also don't have openpty, but we don't
support those I think).
Paolo
next prev parent reply other threads:[~2015-10-06 10:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-03 4:44 [Qemu-devel] [RFC PATCH v4] os-android: Add support to android platform Houcheng Lin
2015-10-06 9:47 ` Stefan Hajnoczi
2015-10-06 10:56 ` Paolo Bonzini [this message]
2015-10-06 12:13 ` Eric Blake
2015-10-06 13:22 ` Paolo Bonzini
2015-10-07 2:05 ` Houcheng Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5613A8DF.3090801@redhat.com \
--to=pbonzini@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=famz@redhat.com \
--cc=houcheng@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=linhaocheng@itri.org.tw \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).