From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56572) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZjR7Q-0002A2-Ey for qemu-devel@nongnu.org; Tue, 06 Oct 2015 08:13:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZjR7N-0004D4-97 for qemu-devel@nongnu.org; Tue, 06 Oct 2015 08:13:20 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34383) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZjR7N-0004CR-3p for qemu-devel@nongnu.org; Tue, 06 Oct 2015 08:13:17 -0400 References: <1443847454-20406-1-git-send-email-houcheng@gmail.com> <20151006094713.GD19089@stefanha-thinkpad> From: Eric Blake Message-ID: <5613BAD6.9090605@redhat.com> Date: Tue, 6 Oct 2015 06:13:10 -0600 MIME-Version: 1.0 In-Reply-To: <20151006094713.GD19089@stefanha-thinkpad> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="J0QAoupQVoI0dn9nVf42FXqlpC9eHHkvE" Subject: Re: [Qemu-devel] [RFC PATCH v4] os-android: Add support to android platform List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi , Houcheng Lin Cc: peter.maydell@linaro.org, famz@redhat.com, kvm@vger.kernel.org, linhaocheng@itri.org.tw, qemu-devel@nongnu.org, pbonzini@redhat.com, alex.bennee@linaro.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --J0QAoupQVoI0dn9nVf42FXqlpC9eHHkvE Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10/06/2015 03:47 AM, Stefan Hajnoczi wrote: > On Sat, Oct 03, 2015 at 12:44:14PM +0800, Houcheng Lin wrote: >> diff --git a/configure b/configure >> index d7c24cd..cda88c1 100755 >> +++ b/include/qemu/osdep.h >> @@ -74,6 +74,14 @@ typedef unsigned int uint_fast16_t; >> typedef signed int int_fast16_t; >> #endif >> =20 >> +#ifdef CONFIG_ANDROID >> +/* >> + * For include the basename prototyping in android. >> + */ >> +#include >=20 > Files that use basename(3) should include libgen.h. Why include it > here? What is using basename(3)? POSIX gives basename(3) a worthless contract - it is free to return non-thread-safe storage. Also, it is not portable to Windows-style drive-letters, so I consider any code using to already be suspect. If you are already writing code to be ported to both Unixy and windows systems, you are better off rolling your own alternative to basename (or better, using something else that has already rolled a portable version for you - while I know gnulib does that, we aren't using gnulib; but I assume glib has something along those lines even though I haven't looked for it). --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --J0QAoupQVoI0dn9nVf42FXqlpC9eHHkvE Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWE7rWAAoJEKeha0olJ0Nqhs8H/A+cb5NsPUCcv4D/dZV6d2EU pNyM0mdSRqMhhrsavAFLXUyb2VJp9zm6VC+dGyL8uX0cuBjNF5G4OY48QJ/WY1so mZrPmM5boQWasvYwqwnD7E7j1dER6/fpYKkec3YVxl7qQ3mBhgeopkSIEsBxPSKc ZtLb9zQGBh9S3eYNrfwQVNKXHndR/6MBboPRSgs3186QTm6HplGPcvhileY3eU+w e80o1VrJEugPzD5AyIk7r5EX5E+xLRxjVhIw+htxdnXfKni0O9RiNlecfTmvRNN+ IRWUI1HZBJCmzsyME7ZXqiNQa2WkEISUUMvb3cAg03gFxo9/l/UJVgwDY6Ezw1s= =2orV -----END PGP SIGNATURE----- --J0QAoupQVoI0dn9nVf42FXqlpC9eHHkvE--