From: Paolo Bonzini <pbonzini@redhat.com>
To: Laszlo Ersek <lersek@redhat.com>, David Gibson <dgibson@redhat.com>
Cc: Pavel Fedin <p.fedin@samsung.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] qobject: Replace property list with GHashTable
Date: Tue, 6 Oct 2015 15:15:42 +0200 [thread overview]
Message-ID: <5613C97E.3030505@redhat.com> (raw)
In-Reply-To: <5613C659.5070108@redhat.com>
On 06/10/2015 15:02, Laszlo Ersek wrote:
>> void object_unparent(Object *obj)
>> {
>> if (obj->parent) {
>> - object_property_del_child(obj->parent, obj, NULL);
>> + g_hash_table_foreach_remove(obj->properties,
This should be obj->parent->properties.
Otherwise, the patch looks good.
Paolo
>> + object_property_del_child, obj);
>> }
>> }
next prev parent reply other threads:[~2015-10-06 13:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-06 12:41 [Qemu-devel] [PATCH] qobject: Replace property list with GHashTable Pavel Fedin
2015-10-06 13:02 ` Laszlo Ersek
2015-10-06 13:15 ` Paolo Bonzini [this message]
2015-10-06 13:36 ` Pavel Fedin
2015-10-06 23:56 ` David Gibson
2015-10-06 23:55 ` David Gibson
2015-10-07 7:53 ` Pavel Fedin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5613C97E.3030505@redhat.com \
--to=pbonzini@redhat.com \
--cc=dgibson@redhat.com \
--cc=lersek@redhat.com \
--cc=p.fedin@samsung.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).